Skip to content

feat(clientServer): add support for extraVolumes in trivy-server#2738

Merged
simar7 merged 1 commit intoaquasecurity:mainfrom
hichem-belhocine:server-extraVolume
Sep 10, 2025
Merged

feat(clientServer): add support for extraVolumes in trivy-server#2738
simar7 merged 1 commit intoaquasecurity:mainfrom
hichem-belhocine:server-extraVolume

Conversation

@hichem-belhocine
Copy link
Copy Markdown
Contributor

@hichem-belhocine hichem-belhocine commented Sep 3, 2025 •
edited
Loading

Refactors values.yaml to introduce two top-level keys:

  • trivy.server.extraVolumes.volumeMounts
  • trivy.server.extraVolumes.volumes

This allows mounting additional ConfigMaps or Secrets into the trivy-server Statefulset

Description

The server needs to get the vulnerability database from docker registry e.g., Artifactory which uses certs

Error:

Failed to verify certificates: x509: certificate signed by unknown authority

Solution

Mounting CAs as a volume solves the issue

Related issues

  • Close #XXX

Remove this section if you don't have related PRs.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Sep 3, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@afdesk
Copy link
Copy Markdown
Contributor

afdesk commented Sep 8, 2025

@hichem-belhocine thanks for your contribution!
could you fix the checks?

@hichem-belhocine
Copy link
Copy Markdown
Contributor Author

hichem-belhocine commented Sep 8, 2025

could you fix the checks?

Done

thanks @afdesk

@hichem-belhocine
Copy link
Copy Markdown
Contributor Author

hichem-belhocine commented Sep 8, 2025

@simar7 could you take a look at this PR when you have time?

afdesk
afdesk reviewed Sep 9, 2025
View reviewed changes
deploy/helm/values.yaml Outdated
replicas: 1

# -- volumes set trivy-server volumes
extraVolumes:
Copy link
Copy Markdown
Contributor

@afdesk afdesk Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hichem-belhocine
what do you think if we add a server server for this block?
something like extraServerVolumes

Copy link
Copy Markdown
Contributor Author

@hichem-belhocine hichem-belhocine Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's OK for me, should i change it?

Copy link
Copy Markdown
Contributor

@afdesk afdesk Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be nice. thanks

Copy link
Copy Markdown
Contributor Author

@hichem-belhocine hichem-belhocine Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@afdesk
Copy link
Copy Markdown
Contributor

afdesk commented Sep 9, 2025

@hichem-belhocine thanks!
this idea looks Ok for me.
left one small comment

@afdesk
Copy link
Copy Markdown
Contributor

afdesk commented Sep 9, 2025

@hichem-belhocine
it seems you need to run mage generate:all

@hichem-belhocine
feat(clientServer): add support for extraVolumes in trivy-server
daa7346 
Refactors values.yaml to introduce two top-level keys:
- trivy.server.extraVolumes.volumeMounts
- trivy.server.extraVolumes.volumes

This allows mounting additional ConfigMaps or Secrets into the trivy-server Statefulset
@hichem-belhocine
Copy link
Copy Markdown
Contributor Author

hichem-belhocine commented Sep 9, 2025

@hichem-belhocine it seems you need to run mage generate:all

Done

afdesk
afdesk approved these changes Sep 10, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@afdesk afdesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hichem-belhocine thanks for your efforts!
LGTM!

@simar7 could you pls take a look too?

@simar7 simar7 merged commit 8049fc7 into aquasecurity:main Sep 10, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simar7 simar7 simar7 approved these changes

+1 more reviewer

@afdesk afdesk afdesk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hichem-belhocine @CLAassistant @afdesk @simar7