Skip to content

fix(policy): show passed checks#2542

Merged
simar7 merged 5 commits intoaquasecurity:mainfrom
afdesk:fix/show-success-checks
May 8, 2025
Merged

fix(policy): show passed checks#2542
simar7 merged 5 commits intoaquasecurity:mainfrom
afdesk:fix/show-success-checks

Conversation

@afdesk
Copy link
Copy Markdown
Contributor

@afdesk afdesk commented May 2, 2025

Description

In some cases, a check result may not contain a message — more details can be found here: #1742 (fixed #1845).

Previously, messages were also missing for all successfully passed checks, and those were being skipped as well.

This PR changes that behavior to ensure successful checks are no longer skipped even if they lack a message.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@github-actions github-actions bot added the bug label May 2, 2025
@afdesk afdesk marked this pull request as ready for review May 6, 2025 05:17
@afdesk afdesk requested a review from simar7 as a code owner May 6, 2025 05:17
@simar7
Copy link
Copy Markdown
Member

simar7 commented May 7, 2025

@mjshastha it lgtm, could you take another look as well?

@simar7 simar7 merged commit 44a0102 into aquasecurity:main May 8, 2025
8 checks passed
@afdesk afdesk deleted the fix/show-success-checks branch May 12, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

reportRecordFailedChecksOnly: false not including successful checks in reports

2 participants