fix(libcap): bump libcap to v1.2.75 & libpsx to v1.2.76-rc1#4688
Conversation
The regression introduced in v1.2.72 https://bugzilla.kernel.org/show_bug.cgi?id=219687 was fixed since 1.2.74 https://web.git.kernel.org/pub/scm/libs/libcap/libcap.git/commit/?id=025f28ca4fe085fbcbf7933d53a42d335744e553 Nevertheless, this bumps libcap to v1.2.75 to match with the upstream libbpfgo version.
94d2bb4 to
fa56872
Compare
|
x86_64 kernels tests passed with glory but libcap v1.2.75 seems to be failing on arm64: some failures
@rscampos, if there are no RC fixes addressing this architecture, I think we should revert libbpfgo and Tracee to versions prior to libcap v1.2.72. Hi there @AndrewGMorgan, have you encountered a similar issue on arm64 following the refactoring mentioned in https://bugzilla.kernel.org/show_bug.cgi?id=219687? Cheers. |
|
Definitely revert to 1.2.71 for stability. 1.2.75 should be fixed for aarch64, so I am concerned this is a new issue. |
|
Are we at a stage where we understand this to be an issue with cap/v1.2.75 that is different from the one described in #4678 ? I am confident that that bug should have been fixed with 1.2.75. Based on the crash dumps visible in this bug from the above test runs ("> some failures"), I don't see any evidence that the |
|
I've just run my The stack traces of the failures in this present bug all seem to implicate something related to |
Firstly I thought that could be a mismatch of the libbpfgo (using an older libcap) but, as you can see, this PR bumped libbpfgo to its latest commit aquasecurity/libbpfgo@c412f16 which is a bump per si. |
As you suggested, @AndrewGMorgan, we're going that way through other PR. But we're going to let this open for discussion and debugging. BTW, thanks for the amazing libcap and family. |
We're using go toolchain 1.24.1 Line 5 in 6bc3c6b libcap regression tests are based on which toolchain? |
|
I regression test against all go tool chains (top of each release from |
|
The dumps come from Tracee cmd. --- EDIT |
|
As listed above the crashes occur exclusively on the following aarch64 kernel versions supported by Tracee: AMZN2 5.10 aarch64, Focal 5.13 aarch64, GKE 5.15 aarch64, Jammy 5.15 aarch64, Lunar 6.2 aarch64, Mantic 6.5 aarch64, and Mantic 6.6 aarch64. However, it appears to work correctly on these versions: Noble 6.8 aarch64, Noble 6.10 aarch64, Noble 6.11 aarch64, and Noble 6.12 aarch64. Could this be due to a (possible) change in the aarch64 signaling mechanism introduced between versions 6.6 and 6.8? Follow an entire crash dump. |
|
I found a stack allocation thing that potentially affects |
|
@AndrewGMorgan Thanks for the new psx v1.2.76-rc1, I've bumped it to. Tests are underway, and I'll update you soon. |
|
All aarch64 tests passed! 🎉 @AndrewGMorgan the change works. Again, thanks a million. |
|
/fast-forward |
…1.2.76-rc1 --- fix(deps): bump libcap to v1.2.75 The regression introduced in v1.2.72 https://bugzilla.kernel.org/show_bug.cgi?id=219687 was fixed since 1.2.74 https://web.git.kernel.org/pub/scm/libs/libcap/libcap.git/commit/?id=025f28ca4fe085fbcbf7933d53a42d335744e553 Nevertheless, this bumps libcap to v1.2.75 to match with the upstream libbpfgo version. commit: main@7fd451953, backport --- fix(deps): bump psx to v1.2.76-rc1 - aquasecurity#4688 (comment) - https://web.git.kernel.org/pub/scm/libs/libcap/libcap.git/commit/?h=psx/v1.2.76-rc1&id=07d8ce731d5fe9063abfef4a77306e273b18b5f3 commit: main@fd2186731f, cherry-pick
…1.2.76-rc1 fix(deps): bump libcap to v1.2.75 The regression introduced in v1.2.72 https://bugzilla.kernel.org/show_bug.cgi?id=219687 was fixed since 1.2.74 https://web.git.kernel.org/pub/scm/libs/libcap/libcap.git/commit/?id=025f28ca4fe085fbcbf7933d53a42d335744e553 Nevertheless, this bumps libcap to v1.2.75 to match with the upstream libbpfgo version. commit: main@7fd451953, backport --- fix(deps): bump psx to v1.2.76-rc1 - aquasecurity#4688 (comment) - https://web.git.kernel.org/pub/scm/libs/libcap/libcap.git/commit/?h=psx/v1.2.76-rc1&id=07d8ce731d5fe9063abfef4a77306e273b18b5f3 commit: main@fd2186731f, cherry-pick
* chore(helpers): reduce gomod noise syncing with main * fix(deps): bump psx to v1.2.76-rc1 - aquasecurity/tracee#4688 (comment) - https://web.git.kernel.org/pub/scm/libs/libcap/libcap.git/commit/?h=psx/v1.2.76-rc1&id=07d8ce731d5fe9063abfef4a77306e273b18b5f3
|
I just made the cap/v1.2.76 release, which includes this fix for the |
Even not required, this aligns libbpfgo that uses cap/psx v1.2.76, see: aquasecurity#4688. This also brings USDT support.
Even not required, this aligns libbpfgo that uses cap/psx v1.2.76, see: #4688. This also brings USDT support.
Even not required, this aligns libbpfgo that uses cap/psx v1.2.76, see: #4688. This also brings USDT support.
Close: #4678
1. Explain what the PR does
fd21867 fix(deps): bump psx to v1.2.76-rc1
fa56872 fix(deps): bump to libbpfgo using libcap v1.2.75
7fd4519 fix(deps): bump libcap to v1.2.75
fd21867 fix(deps): bump psx to v1.2.76-rc1
7fd4519 fix(deps): bump libcap to v1.2.75
2. Explain how to test it
3. Other comments