squash! check windowsBits === 8 early

aqrln · aqrln · commit bf63a37f832f · 2017-05-18T18:53:35.000+03:00
diff --git a/lib/zlib.js b/lib/zlib.js
@@ -193,6 +193,10 @@ class Zlib extends Transform {
           opts.windowBits > constants.Z_MAX_WINDOWBITS) {
         throw new RangeError('Invalid windowBits: ' + opts.windowBits);
       }
+      if (mode === constants.DEFLATERAW &&
+          opts.windowBits === 8) {
+        throw new RangeError('Unsupported windowBits for DeflateRaw: 8');
+      }
     }
 
     if (opts.level) {
diff --git a/test/parallel/test-zlib-deflate-unsupported-windowbits.js b/test/parallel/test-zlib-deflate-unsupported-windowbits.js
@@ -10,4 +10,4 @@ const zlib = require('zlib');
 // (http://zlib.net/manual.html#Advanced)
 assert.throws(() => {
   zlib.createDeflateRaw({ windowBits: 8 });
-}, /^Error: Init error$/);
+}, /^RangeError: Unsupported windowBits for DeflateRaw: 8$/);

Original file line number	Diff line number	Diff line change
`@@ -193,6 +193,10 @@ class Zlib extends Transform {`
`193`	`193`	`opts.windowBits > constants.Z_MAX_WINDOWBITS) {`
`194`	`194`	`throw new RangeError('Invalid windowBits: ' + opts.windowBits);`
`195`	`195`	`}`
	`196`	`+ if (mode === constants.DEFLATERAW &&`
	`197`	`+ opts.windowBits === 8) {`
	`198`	`+ throw new RangeError('Unsupported windowBits for DeflateRaw: 8');`
	`199`	`+ }`
`196`	`200`	`}`
`197`	`201`
`198`	`202`	`if (opts.level) {`