Fix flakey tests related to identity name ordering. #863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
sliverc
approved these changes
Aug 6, 2019
smira
force-pushed
the
openpgp-flakey-test
branch
from
9867371 to
222ddb2
Compare
Codecov Report
@@ Coverage Diff @@
## master #863 +/- ##
=========================================
Coverage ? 64.05%
=========================================
Files ? 51
Lines ? 6537
Branches ? 0
=========================================
Hits ? 4187
Misses ? 1843
Partials ? 507
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #863 +/- ##
=========================================
+ Coverage 64.08% 64.1% +0.01%
=========================================
Files 51 51
Lines 6555 6560 +5
=========================================
+ Hits 4201 4205 +4
- Misses 1849 1850 +1
Partials 505 505
Continue to review full report at Codecov.
|
Contributor
Author
|
Rebased without changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identities were not sorted, so randomly it might print them in different order breaking tests.
Also added filters to download less data.