Skip to content

Don't remove API file socket if it exists and usable #807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
smira merged 2 commits into from
Jan 20, 2019
Merged

Don't remove API file socket if it exists and usable #807

smira merged 2 commits into from
Jan 20, 2019

Conversation

@smira
Copy link
Contributor

@smira smira commented Jan 19, 2019

Fixes #806

Also updates linter config & fixes linting errors.

@smira smira mentioned this pull request Jan 19, 2019
Closed
@smira smira added this to the 1.4.0 milestone Jan 19, 2019
This was referenced Jan 19, 2019
Merged
Merged
@codecov
Copy link

codecov bot commented Jan 19, 2019

Codecov Report

Merging #807 into master will increase coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #807      +/-   ##
==========================================
+ Coverage   64.06%   64.11%   +0.04%     
==========================================
  Files          51       51              
  Lines        6506     6501       -5     
==========================================
  Hits         4168     4168              
+ Misses       1831     1825       -6     
- Partials      507      508       +1
Impacted Files Coverage Δ
query/lex.go 87.09% <ø> (+2.72%) ⬆️
utils/utils.go 0% <0%> (ø) ⬆️
http/download.go 76.47% <0%> (ø) ⬆️
deb/remote.go 62.88% <0%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a64807e...22848b0. Read the comment docs.

@smira
Copy link
Contributor Author

smira commented Jan 20, 2019

Merging this to fix build failures

@smira smira merged commit 50f8cfb into master Jan 20, 2019
@sliverc sliverc deleted the 806-file-socket branch January 21, 2019 07:46
@syphernl syphernl mentioned this pull request Jul 10, 2019
Closed
smira added a commit to smira/aptly-fork that referenced this pull request Jul 12, 2019
@smira
Revert "Don't remove API file socket if it exists and it's usable"
ed7b807 
See PR aptly-dev#807

Fixes: aptly-dev#849

This reverts commit 22848b0.
@smira smira mentioned this pull request Jul 12, 2019
Merged
smira added a commit that referenced this pull request Jul 12, 2019
@smira
Revert "Don't remove API file socket if it exists and it's usable"
70cd11e 
See PR #807

Fixes: #849

This reverts commit 22848b0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.4.0

Development

Successfully merging this pull request may close these issues.

Unable to set permissions on the unix socket

2 participants

@smira