Skip to content

Conversation

@stnguyen90
Copy link
Contributor

What does this PR do?

Add a GH workflow to make sure the SDK builds and tests pass.

Test Plan

Tested and confirmed the workflow was created successfully:

image

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

Yes

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a GitHub workflow for the Dart SDK to run automated analysis and testing on pull requests, improving the CI/CD pipeline for code quality assurance.

  • Adds a new GitHub Actions workflow file that runs Dart analysis and tests
  • Registers the workflow file in the SDK generator configuration

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
templates/dart/.github/workflows/test.yml New GitHub Actions workflow that runs dart analyze and dart test on pull requests
src/SDK/Language/Dart.php Registers the new test workflow file in the SDK generator file configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: dart-lang/setup-dart@v1
Copy link

Copilot AI Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider pinning to a specific version or using a more recent version like dart-lang/[email protected] for better reproducibility and access to latest features.

Suggested change
- uses: dart-lang/setup-dart@v1
- uses: dart-lang/setup-dart@v1.6

Copilot uses AI. Check for mistakes.
@stnguyen90 stnguyen90 merged commit 95d3dd7 into master Aug 19, 2025
38 checks passed
@stnguyen90 stnguyen90 deleted the chore-dart-test branch August 19, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants