-
Notifications
You must be signed in to change notification settings - Fork 4.9k
chore: update dart 16.1.0, flutter 17.0.2 and cli 8.2.2 #10161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 Walkthrough## Walkthrough
The configuration file `app/config/platforms.php` was updated to increment version numbers for three SDK entries: Flutter SDK under the client platform from `17.0.1` to `17.0.2`, CLI SDK under the console platform from `8.2.1` to `8.2.2`, and Dart SDK under the server platform from `16.0.0` to `16.1.0`. Additionally, a new key `'repoBranch'` with the value `'master'` was added to the CLI SDK configuration. In `src/Appwrite/Platform/Tasks/SDKs.php`, the git commands were modified to use a dynamic branch name sourced from the SDK configuration (`repoBranch`), defaulting to `'main'` if not set, replacing the previously hardcoded `'main'` branch name.
## Possibly related PRs
- appwrite/appwrite#10088: Modifies SDK version numbers and adjusts git branch handling logic for repository operations, similar to this PR’s dynamic branch name implementation.
- appwrite/appwrite#10007: Updates CLI SDK version numbers in the configuration file, related by modifying SDK version entries.
- appwrite/appwrite#10136: Updates the CLI SDK version from 8.1.1 to 8.2.0 and modifies the CLI SDK version setting in the platforms configuration file, related to version increments.
## Suggested reviewers
- christyjacob4
- stnguyen90
- lohanidamodar📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Security Scan Results for PRDocker Image Scan Results
Source Code Scan Results🎉 No vulnerabilities found! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (5)
composer.lockis excluded by!**/*.lockdocs/examples/1.7.x/server-dart/examples/databases/upsert-document.mdis excluded by!docs/examples/**docs/examples/1.7.x/server-dart/examples/databases/upsert-documents.mdis excluded by!docs/examples/**docs/sdks/dart/CHANGELOG.mdis excluded by!docs/sdks/**docs/sdks/flutter/CHANGELOG.mdis excluded by!docs/sdks/**
📒 Files selected for processing (1)
app/config/platforms.php(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Setup & Build Appwrite Image
- GitHub Check: Setup & Build Appwrite Image
- GitHub Check: scan
🔇 Additional comments (1)
app/config/platforms.php (1)
60-64: Flutter SDK correctly bumped to 17.0.2The new Flutter version aligns with the PR objective. No other issues spotted here.
✨ Benchmark results
⚡ Benchmark Comparison
|
What does this PR do?
updating sdks.
Test Plan
Related PRs and Issues
Checklist