Skip to content

Update to sylabs/sif v2.15.2#228

Merged
DrDaveD merged 2 commits intoapptainer:mainfrom
DrDaveD:sylabsv2.15.2
Mar 11, 2024
Merged

Update to sylabs/sif v2.15.2#228
DrDaveD merged 2 commits intoapptainer:mainfrom
DrDaveD:sylabsv2.15.2

Conversation

@DrDaveD
Copy link
Contributor

@DrDaveD DrDaveD commented Mar 11, 2024

This updates to the sylabs/sif v2.15.2 by pulling in

the latter of which had a PR description of

revive linter now checks for this as of v1.3.7.

revive linter now checks for this as of v1.3.7.

Signed-off-by: Dave Dykstra <[email protected]>
@codecov
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 65.23%. Comparing base (8eb8c31) to head (1cf9c09).
Report is 1 commits behind head on main.

Files Patch % Lines
cmd/siftool/siftool.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #228   +/-   ##
=======================================
  Coverage   65.23%   65.23%           
=======================================
  Files          34       34           
  Lines        3268     3268           
=======================================
  Hits         2132     2132           
  Misses        980      980           
  Partials      156      156           
Flag Coverage Δ
unittests 65.23% <88.88%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DrDaveD DrDaveD merged commit 425b739 into apptainer:main Mar 11, 2024
@DrDaveD DrDaveD deleted the sylabsv2.15.2 branch March 11, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants