Merge sylabs/sif through v2.12.0#200
Merged
DrDaveD merged 4 commits intoapptainer:mainfrom Aug 21, 2023
Merged
Conversation
Switch from using golden file testing for TestGroupSigner_Sign and TestSigner_Sign, to reduce the workload when the data format of the openpgp module we're using changes. Signed-off-by: Dave Dykstra <[email protected]>
…19771a1 to v0.0.0-20230710112148-e01326fd72eb Update test corpus images. Also, remove unit tests that display dumped digital signatures, since the format is not consistent. Signed-off-by: Dave Dykstra <[email protected]>
Signed-off-by: Dave Dykstra <[email protected]>
Rather than using crypto.SHA256.New(), use sha256.New() directly to ensure the SHA256 algorithm is available. Signed-off-by: Dave Dykstra <[email protected]>
ikaneshiro
approved these changes
Aug 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pulls in PRs
bringing sif up to date with their v2.12.0. Issues that were addressed were
The original PR descriptions were: