fix(azure): function call issues in deepseek-V3#221
Merged
appleboy merged 1 commit intoappleboy:mainfrom Feb 26, 2025
Merged
Conversation
- Add `strings` package to imports for string manipulation. - Extend model checking logic to include models containing `"deepseek"` in their name. Signed-off-by: Yang,Jingrong <[email protected]>
appleboy
changed the title
appleboy
approved these changes
Feb 26, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #221 +/- ##
==========================================
- Coverage 21.96% 5.98% -15.98%
==========================================
Files 8 31 +23
Lines 346 1553 +1207
==========================================
+ Hits 76 93 +17
- Misses 264 1454 +1190
Partials 6 6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The function call of Deepseek-V3 is currently encountering problems, making it unable to work with tool calls. See doc.
Solution
Fortunately, Deepseek-V3 operates correctly when using the ChatCompletion method, similar to OpenAI's models with the pattern
o\d(-(mini|preview))?. This pull request aims to implement this solution.Proposed Changes
This pull request includes the necessary modifications to ensure that Deepseek-V3 can function properly with tool calls by utilizing the ChatCompletion method.
Testing
The changes have been thoroughly tested to ensure compatibility and functionality with tool calls.
Approval
Please review the proposed changes and provide your approval to proceed with the integration.