Skip to content

Enable documentation comment validation in swift-format #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
czechboy0 merged 1 commit into from
Oct 23, 2023
Merged

Enable documentation comment validation in swift-format #18

czechboy0 merged 1 commit into from
Oct 23, 2023

Conversation

@PARAIPAN9
Copy link
Contributor

@PARAIPAN9 PARAIPAN9 commented Oct 23, 2023

Motivation

Modifications

  • Enable new rules in swift-format and address changes required

Result

  • New swift format rules will be implemented

Test Plan

  • Run the tests

czechboy0
czechboy0 approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@czechboy0 czechboy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @PARAIPAN9!

@czechboy0
Copy link
Contributor

czechboy0 commented Oct 23, 2023

@swift-server-bot add to allowlist

@PARAIPAN9
Copy link
Contributor Author

PARAIPAN9 commented Oct 23, 2023

You're welcome! I'm glad I could contribute.

@czechboy0 czechboy0 merged commit aceadfd into apple:main Oct 23, 2023
@simonjbeaumont simonjbeaumont added the semver/none No version bump required. label Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@czechboy0 czechboy0 czechboy0 approved these changes

Assignees

No one assigned

Labels

semver/none No version bump required.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PARAIPAN9 @czechboy0 @simonjbeaumont