-
Notifications
You must be signed in to change notification settings - Fork 40
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: apple/swift-openapi-urlsession
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.0.0-alpha.1
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: apple/swift-openapi-urlsession
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.0.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 8 commits
- 9 files changed
- 4 contributors
Commits on Nov 30, 2023
-
Add visionOS platform support (#38)
### Motivation While this isn't technically necessary, as all versions of a platform not explicitly mentioned are assumed to be supported, it's better to be explicit here. ### Modifications Add `visionOS(.v1)` to the list of supported platforms. ### Result Clearer support matrix. ### Test Plan N/A, this is basically just a documentation change.
Configuration menu - View commit details
-
Copy full SHA for d16dc2f - Browse repository at this point
Copy the full SHA d16dc2fView commit details -
Configuration menu - View commit details
-
Copy full SHA for c703e84 - Browse repository at this point
Copy the full SHA c703e84View commit details
Commits on Dec 1, 2023
-
Remove no-longer-needed
@preconcurrencys (#35)See apple/swift-openapi-generator#396. Co-authored-by: Honza Dvorsky <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4baf5fa - Browse repository at this point
Copy the full SHA 4baf5faView commit details -
Explicit dependency on HTTPTypes (#39)
### Motivation Recent SwiftPM versions seem to be a bit stricter about using (i.e., `import ...`) transitive dependencies without explicitly declaring them as direct dependencies. ### Modifications Explicitly depend on the HTTPTypes module from swift-http-types. ### Result More explicitly declare the dependency graph. ### Test Plan All tests pass.
Configuration menu - View commit details
-
Copy full SHA for 4290b2c - Browse repository at this point
Copy the full SHA 4290b2cView commit details
Commits on Dec 2, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e8c1733 - Browse repository at this point
Copy the full SHA e8c1733View commit details
Commits on Dec 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d0dafbf - Browse repository at this point
Copy the full SHA d0dafbfView commit details -
### Motivation Ready the docs for 1.0. ### Modifications Updated README.md and documentation, updated the runtime dependency. ### Result Ready for 1.0. ### Test Plan Reviewed locally.
Configuration menu - View commit details
-
Copy full SHA for 144464e - Browse repository at this point
Copy the full SHA 144464eView commit details -
More checks for task cancellation and tests (#44)
### Motivation In our fallback, buffered implementation, we did not use a task cancellation handler so were not proactively cancelling the URLSession task when the Swift concurrency task was cancelled. Additionally, while we _did_ have a task cancellation handler in the streaming implementation, so the URLSession task would be cancelled, we were not actively checking for task cancellation as often as we could. ### Modifications - Added more cooperative task cancellation. - Added tests for both implementations that when the parent task for the client request is cancelled that we get something sensible. Note that in some cases, the request will succeed. In the cases where the request fails, it will surface as a `ClientError` to the user where the `underlyingError` is either `Swift.CancellationError` or `URLError` with `code == .cancelled`. ### Result More cooperative task and URLSession task cancellation and more thorough tests. ### Test Plan Added unit tests.
Configuration menu - View commit details
-
Copy full SHA for aac0a82 - Browse repository at this point
Copy the full SHA aac0a82View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 1.0.0-alpha.1...1.0.0