Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: apple/swift-openapi-urlsession
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.0.0-alpha.1
Choose a base ref
...
head repository: apple/swift-openapi-urlsession
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.0.0
Choose a head ref
  • 8 commits
  • 9 files changed
  • 4 contributors

Commits on Nov 30, 2023

  1. Add visionOS platform support (#38)

    ### Motivation
    
    While this isn't technically necessary, as all versions of a platform
    not explicitly mentioned are assumed to be supported, it's better to be
    explicit here.
    
    ### Modifications
    
    Add `visionOS(.v1)` to the list of supported platforms.
    
    ### Result
    
    Clearer support matrix.
    
    ### Test Plan
    
    N/A, this is basically just a documentation change.
    czechboy0 authored Nov 30, 2023
    Configuration menu
    Copy the full SHA
    d16dc2f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c703e84 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. Configuration menu
    Copy the full SHA
    4baf5fa View commit details
    Browse the repository at this point in the history
  2. Explicit dependency on HTTPTypes (#39)

    ### Motivation
    
    Recent SwiftPM versions seem to be a bit stricter about using (i.e.,
    `import ...`) transitive dependencies without explicitly declaring them
    as direct dependencies.
    
    ### Modifications
    
    Explicitly depend on the HTTPTypes module from swift-http-types.
    
    ### Result
    
    More explicitly declare the dependency graph.
    
    ### Test Plan
    
    All tests pass.
    czechboy0 authored Dec 1, 2023
    Configuration menu
    Copy the full SHA
    4290b2c View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2023

  1. Configuration menu
    Copy the full SHA
    e8c1733 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. Configuration menu
    Copy the full SHA
    d0dafbf View commit details
    Browse the repository at this point in the history
  2. Prep 1.0 (#43)

    ### Motivation
    
    Ready the docs for 1.0.
    
    ### Modifications
    
    Updated README.md and documentation, updated the runtime dependency.
    
    ### Result
    
    Ready for 1.0.
    
    ### Test Plan
    
    Reviewed locally.
    czechboy0 authored Dec 11, 2023
    Configuration menu
    Copy the full SHA
    144464e View commit details
    Browse the repository at this point in the history
  3. More checks for task cancellation and tests (#44)

    ### Motivation
    
    In our fallback, buffered implementation, we did not use a task
    cancellation handler so were not proactively cancelling the URLSession
    task when the Swift concurrency task was cancelled. Additionally, while
    we _did_ have a task cancellation handler in the streaming
    implementation, so the URLSession task would be cancelled, we were not
    actively checking for task cancellation as often as we could.
    
    ### Modifications
    
    - Added more cooperative task cancellation.
    - Added tests for both implementations that when the parent task for the
    client request is cancelled that we get something sensible. Note that in
    some cases, the request will succeed. In the cases where the request
    fails, it will surface as a `ClientError` to the user where the
    `underlyingError` is either `Swift.CancellationError` or `URLError` with
    `code == .cancelled`.
    
    ### Result
    
    More cooperative task and URLSession task cancellation and more thorough
    tests.
    
    ### Test Plan
    
    Added unit tests.
    simonjbeaumont authored Dec 11, 2023
    Configuration menu
    Copy the full SHA
    aac0a82 View commit details
    Browse the repository at this point in the history
Loading