-
Notifications
You must be signed in to change notification settings - Fork 40
Comparing changes
Open a pull request
base repository: apple/swift-openapi-urlsession
base: 0.3.1
head repository: apple/swift-openapi-urlsession
compare: 1.0.0
- 14 commits
- 16 files changed
- 4 contributors
Commits on Nov 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7d33846 - Browse repository at this point
Copy the full SHA 7d33846View commit details
Commits on Nov 27, 2023
-
Prep for 1.0 alpha, adapted to runtime changes in main (#31)
### Motivation On main, the HTTPBody length type changed from Int to Int64. ### Modifications Adapted the transport with this change. ### Result Repo builds again when using the latest runtime. ### Test Plan Adapted tests.
Configuration menu - View commit details
-
Copy full SHA for fa75a83 - Browse repository at this point
Copy the full SHA fa75a83View commit details -
Move to Swift 5.9 as the minimum version (#32)
### Motivation Part of addressing apple/swift-openapi-generator#75 and apple/swift-openapi-generator#119. ### Modifications Bumped Swift tools version to 5.9 and made the `ExistentialAny` build setting unconditional. ### Result Building the package requires 5.9 now. ### Test Plan Ran tests, all passed when using a Swift 5.9 toolchain.
Configuration menu - View commit details
-
Copy full SHA for 0b99785 - Browse repository at this point
Copy the full SHA 0b99785View commit details -
Remove AsyncStream.makeStream backports now we support only Swift 5.9+ (
#34) ### Motivation We had some code in an `#if swift(<5.9)` block, which can now be removed because we only support Swift 5.9 and newer. ### Modifications Remove code required to support Swift 5.8. ### Result Removed dead code. ### Test Plan Tests pass.
Configuration menu - View commit details
-
Copy full SHA for 0e75335 - Browse repository at this point
Copy the full SHA 0e75335View commit details -
Add missing available annotation to streaming tests (#33)
### Motivation The tests had a missing `@available` annotation which meant that they didn't build iOS (annoyingly, when building for macOS, these things are not checked so things were building fine locally). ### Modifications Add missing available annotation to streaming tests. ### Result Builds for iOS again. ### Test Plan Local testing, selecting generic iOS destination in Xcode. This failed before this patch, and succeeds with it. Signed-off-by: Si Beaumont <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5e704f1 - Browse repository at this point
Copy the full SHA 5e704f1View commit details
Commits on Nov 28, 2023
-
Bump to 1.0.0-alpha.1 ### Motivation Prepare for 1.0.0-alpha.1. ### Modifications - Updated runtime dependency. - Updated docs. ### Result Ready to tag 1.0.0-alpha.1. ### Test Plan All tests pass. Reviewed by: simonjbeaumont Builds: ✔︎ pull request validation (5.10) - Build finished. ✔︎ pull request validation (5.9) - Build finished. ✔︎ pull request validation (nightly) - Build finished. ✔︎ pull request validation (soundness) - Build finished. #36Configuration menu - View commit details
-
Copy full SHA for d038c89 - Browse repository at this point
Copy the full SHA d038c89View commit details
Commits on Nov 30, 2023
-
Add visionOS platform support (#38)
### Motivation While this isn't technically necessary, as all versions of a platform not explicitly mentioned are assumed to be supported, it's better to be explicit here. ### Modifications Add `visionOS(.v1)` to the list of supported platforms. ### Result Clearer support matrix. ### Test Plan N/A, this is basically just a documentation change.
Configuration menu - View commit details
-
Copy full SHA for d16dc2f - Browse repository at this point
Copy the full SHA d16dc2fView commit details -
Configuration menu - View commit details
-
Copy full SHA for c703e84 - Browse repository at this point
Copy the full SHA c703e84View commit details
Commits on Dec 1, 2023
-
Remove no-longer-needed
@preconcurrencys (#35)See apple/swift-openapi-generator#396. Co-authored-by: Honza Dvorsky <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4baf5fa - Browse repository at this point
Copy the full SHA 4baf5faView commit details -
Explicit dependency on HTTPTypes (#39)
### Motivation Recent SwiftPM versions seem to be a bit stricter about using (i.e., `import ...`) transitive dependencies without explicitly declaring them as direct dependencies. ### Modifications Explicitly depend on the HTTPTypes module from swift-http-types. ### Result More explicitly declare the dependency graph. ### Test Plan All tests pass.
Configuration menu - View commit details
-
Copy full SHA for 4290b2c - Browse repository at this point
Copy the full SHA 4290b2cView commit details
Commits on Dec 2, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e8c1733 - Browse repository at this point
Copy the full SHA e8c1733View commit details
Commits on Dec 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d0dafbf - Browse repository at this point
Copy the full SHA d0dafbfView commit details -
### Motivation Ready the docs for 1.0. ### Modifications Updated README.md and documentation, updated the runtime dependency. ### Result Ready for 1.0. ### Test Plan Reviewed locally.
Configuration menu - View commit details
-
Copy full SHA for 144464e - Browse repository at this point
Copy the full SHA 144464eView commit details -
More checks for task cancellation and tests (#44)
### Motivation In our fallback, buffered implementation, we did not use a task cancellation handler so were not proactively cancelling the URLSession task when the Swift concurrency task was cancelled. Additionally, while we _did_ have a task cancellation handler in the streaming implementation, so the URLSession task would be cancelled, we were not actively checking for task cancellation as often as we could. ### Modifications - Added more cooperative task cancellation. - Added tests for both implementations that when the parent task for the client request is cancelled that we get something sensible. Note that in some cases, the request will succeed. In the cases where the request fails, it will surface as a `ClientError` to the user where the `underlyingError` is either `Swift.CancellationError` or `URLError` with `code == .cancelled`. ### Result More cooperative task and URLSession task cancellation and more thorough tests. ### Test Plan Added unit tests.
Configuration menu - View commit details
-
Copy full SHA for aac0a82 - Browse repository at this point
Copy the full SHA aac0a82View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 0.3.1...1.0.0