Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: apple/swift-openapi-runtime
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.4.0
Choose a base ref
...
head repository: apple/swift-openapi-runtime
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.4.1
Choose a head ref
  • 4 commits
  • 14 files changed
  • 2 contributors

Commits on Jun 11, 2024

  1. Swift 6 prep - Part 1 (#106)

    ### Motivation
    
    Fixes to get closer to building in Swift 6 mode without diagnostics.
    
    ### Modifications
    
    - Made two public types Sendable
    - s/#file/#filePath in tests
    
    ### Result
    
    Builds with fewer warnings when trying Swift 6 mode (will open another
    PR for the remaining work).
    
    ### Test Plan
    
    Unit tests passed.
    czechboy0 authored Jun 11, 2024
    Configuration menu
    Copy the full SHA
    acb1838 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. Fixing Issues with Async Upstream (#108)

    ### Motivation
    
    Fixing Issues with Building in Swift 6 for Linux
    
    ### Modifications
    
    * Fix Issues with Upstream Iterator
    
    ### Result
    
    Compatability with Swift 6 on Linux
    
    ### Test Plan
    
    TBD
    leogdion authored Jul 2, 2024
    Configuration menu
    Copy the full SHA
    e80046b View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Support NSNull in OpenAPIContainer types (#109)

    ### Motivation
    
    When receiving containers from adopter code, there might be NSNull
    values, which represent a nil value.
    
    Previously, this value would not be treated as nil, instead it'd throw
    an error as an unrecognized type.
    
    ### Modifications
    
    Handle NSNull and treat it as nil.
    
    ### Result
    
    You can provide a container with an NSNull nested value and it'll get
    encoded correctly.
    
    ### Test Plan
    
    Added a unit test.
    czechboy0 authored Jul 17, 2024
    Configuration menu
    Copy the full SHA
    39fa3ec View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Improved encoding of NSNumber in OpenAPIValueContainer (#110)

    Improved encoding of NSNumber in OpenAPIValueContainer
    
    ### Motivation
    
    When getting CoreFoundation/Foundation types, especially numbers, they automatically bridge to Swift types like Bool, Int, etc. That casting is pretty flexible, and allows e.g. casting a number into a boolean, which isn't desired when encoding into JSON, as `false` and `0` represent very different values.
    
    Previously, we relied on the automatic casting to know how to encode values, however that produced incorrect results in some cases.
    
    ### Modifications
    
    Add explicit handling of CF/NS types and try to encode using that new method before falling back to testing for native Swift types. This ensures that the original intention of the creator of the CF/NS types doesn't get lost in encoding.
    
    ### Result
    
    Correct encoding into JSON of types produced in the CF/NS world, like JSONSerialization.
    
    ### Test Plan
    
    Added unit tests.
    
    
    Reviewed by: simonjbeaumont
    
    Builds:
         ✔︎ pull request validation (5.10) - Build finished. 
         ✔︎ pull request validation (5.9) - Build finished. 
         ✔︎ pull request validation (5.9.0) - Build finished. 
         ✔︎ pull request validation (api breakage) - Build finished. 
         ✔︎ pull request validation (docc test) - Build finished. 
         ✔︎ pull request validation (integration test) - Build finished. 
         ✔︎ pull request validation (nightly) - Build finished. 
         ✔︎ pull request validation (soundness) - Build finished. 
    
    #110
    czechboy0 authored Jul 19, 2024
    Configuration menu
    Copy the full SHA
    71fcfa7 View commit details
    Browse the repository at this point in the history
Loading