Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: apple/swift-openapi-runtime
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.1.2
Choose a base ref
...
head repository: apple/swift-openapi-runtime
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.1.3
Choose a head ref
  • 2 commits
  • 5 files changed
  • 3 contributors

Commits on Jun 9, 2023

  1. Add integration test CI check (#17)

    ### Motivation
    
    We want to make sure that we don't unknowingly introduce changes in the
    runtime
    that break the generator, which relies on its SPI.
    
    We have an package in a subdirectory in the generator repo that we can
    be used
    as an integration test to gate changes to the various repos in Swift
    OpenAPI
    project, including the runtime package.
    
    The generator repo also contains a script that can be used to clone the
    integration test package and use `swift package edit` to override a
    dependency
    to check it still functions with the proposed changes.
    
    ### Modifications
    
    - Bring in the `run-integraton-test.sh` script from the generator repo.
    - Run this script as part of the soundness pipeline.
    
    ### Result
    
    On each pull request, the integration test package will be built with
    the
    changes proposed in the pull request.
    
    ### Test Plan
    
    The CI pipeline for this PR will run the integration test because it's
    been
    added to the soundness script, which is run as part of an existing CI
    pipeline.
    
    I have also validated this locally:
    
    ```console
    ❯ docker-compose -f docker/docker-compose.yaml run --build
    soundness
    ...
    ** Running /code/scripts/run-integration-test.sh...
    ...
    ** Extracting name for Swift package: /code
    ** Overriding dependency in /code/tmp.run-integration-test.sh.uyS9Hf8siA.noindex/swift-openapi-generator/IntegrationTest on swift-openapi-runtime to use /code
    ...
    Build complete! (42.53s)
    ** ✅ Successfully built integration test package.
    ** ✅ All soundness check(s) passed.
    ```
    
    ### Notes
    
    This PR adds the integration test to the soundness script, but we
    probably want
    to split this out into its own pipeline in the future.
    
    Signed-off-by: Si Beaumont <[email protected]>
    simonjbeaumont authored Jun 9, 2023
    Configuration menu
    Copy the full SHA
    b7ae7af View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2023

  1. Relax minimum platforms to macOS 10.15, iOS 13, tvOS 13, and watchOS 6 (

    #18)
    
    ### Motivation
    
    Reduce deployment target by 3 versions to gain more adoption.
    
    ### Modifications
    
    - Reduced deployment targets by 3 versions
    - Modified `Converter#renderedRequestPath` to support iOS 13
    
    ### Result
    
    Deployment target will be reduced by 3 versions.
    
    ### Related issues
    
    - Related to apple/swift-openapi-generator#62
    
    ### Related PRs
    
    - Paired with apple/swift-openapi-generator#63
    
    ---------
    
    Co-authored-by: andrewelliott <>
    Co-authored-by: Honza Dvorsky <[email protected]>
    andrewse02 and czechboy0 authored Jun 13, 2023
    Configuration menu
    Copy the full SHA
    02ae849 View commit details
    Browse the repository at this point in the history
Loading