Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: apple/swift-openapi-generator
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.10.0
Choose a base ref
...
head repository: apple/swift-openapi-generator
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.10.1
Choose a head ref
  • 1 commit
  • 3 files changed
  • 1 contributor

Commits on Jul 23, 2025

  1. Command plugin should skip irrelevant targets when run without --targ…

    …et argument (#798)
    
    ### Motivation
    
    In #795 we adjusted the logic of the command plugin because errors were
    not propagating properly. As a result, we regressed behaviour when the
    command plugin was run without any `--target` argument. In this mode,
    the plugin runs on all targets. When it detects a misconfigured target
    it errors, as it should. However, the classification of misconfigured
    target included targets that were not intended for code generation at
    all, resulting in errors running the command plugin on packages with
    others targets.
    
    ### Modifications
    
    - Add command plugin generation step to integration test
    - If the command plugin is running without a `--target` argument and
    cannot find _any_ of the required files, skip that target.
    
    ### Result
    
    - Manual code generation with the command plugin fixed for packages with
    other targets.
    - Fixes #797.
    
    ### Test Plan
    
    This PR includes two commits. The first adds a step to the integration
    test, which runs the command plugin on the integration test package.
    This will fail in CI. Then the second commit will provide the fix, which
    should pass in CI. The commits will then be squash merged.
    simonjbeaumont authored Jul 23, 2025
    Configuration menu
    Copy the full SHA
    f4f6f9b View commit details
    Browse the repository at this point in the history
Loading