Fix benchmark diff scraping for path-qualified markers#3609
Merged
Conversation
fallintoplace
marked this pull request as ready for review
May 26, 2026 22:21
Lukasa
enabled auto-merge (squash)
June 22, 2026 12:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
scripts/check_benchmark_thresholds.shstarted printing path-qualified diff markers in #3602 so multi-package benchmark runs can identify which package produced each diff.dev/thresholds-from-benchmark-output.shstill scrapes the old exact marker line, which means local threshold updates from CI logs can miss the diff entirely once the new marker format appears.Changes
Relax the scraper to match the stable
=== BEGIN DIFFprefix instead of the old exact line, preserving compatibility with both the original marker and the newer path-qualified form.Validation
bash -n dev/thresholds-from-benchmark-output.sh=== BEGIN DIFF ===and=== BEGIN DIFF (Benchmarks) ===sample log lines