Repository navigation
Make TestMetrics.FullKey tolerate repeated dimension names - #244
Merged
kukushechkin merged 1 commit intoSep 10, 2026
Merged
Conversation
kukushechkin
approved these changes
Sep 10, 2026
kukushechkin
left a comment
Contributor
There was a problem hiding this comment.
Thank you @lenamonj!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestMetricstraps when a metric is created with a repeated dimension name.Motivation:
TestMetrics.FullKeyhashes and compares its dimensions throughDictionary(uniqueKeysWithValues:), which traps on a repeated name:The metrics API accepts that input and every other factory carries it through.
Modifications:
hash(into:)and==read the dimensions sorted by name then value: identity stays order-insensitive, both read the same representation, and repeated names are kept. One test, which crashes without the fix.Result:
TestMetricsrecords the instrument instead of killing the test process.