Skip to content

Revert matchIndex feature (release-7.2) #9992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jzhou77 merged 1 commit into from
Apr 19, 2023
Merged

Revert matchIndex feature (release-7.2) #9992

jzhou77 merged 1 commit into from
Apr 19, 2023

Conversation

@flowguru
Copy link
Contributor

@flowguru flowguru commented Apr 17, 2023 •
edited
Loading

backporting #9862

20230417-200222-haofu-666e2b9a9469a2ad

Replace this text with your description here...

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@flowguru
Revert matchIndex feature
e730ec4 
It is not protocol compatible, revert it to avoid deployment issue.
Will have a new PR to have the feature if moving forward.
@flowguru flowguru changed the title Revert matchIndex feature Revert matchIndex feature (release-7.2) Apr 17, 2023
@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Apr 17, 2023

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Apr 17, 2023

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

  • Commit ID: e730ec4
  • Duration 0:27:30
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Apr 17, 2023

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: e730ec4
  • Duration 1:00:32
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Apr 17, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: e730ec4
  • Duration 1:26:58
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Apr 17, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: e730ec4
  • Duration 3:00:26
  • Result: ❌ FAILED
  • Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@flowguru flowguru requested a review from jzhou77 April 18, 2023 02:00
@flowguru flowguru requested a review from halfprice April 18, 2023 17:27
@jzhou77 jzhou77 merged commit 25bc143 into apple:release-7.2 Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jzhou77 jzhou77 jzhou77 approved these changes

+1 more reviewer

@halfprice halfprice halfprice approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@flowguru @fdb-windows-ci @foundationdb-ci @halfprice @jzhou77