Skip to content

Remove printable() from TSS trace events #9889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jzhou77 merged 1 commit into from
Apr 4, 2023
Merged

Remove printable() from TSS trace events #9889

jzhou77 merged 1 commit into from
Apr 4, 2023

Conversation

@jzhou77
Copy link
Contributor

@jzhou77 jzhou77 commented Apr 4, 2023

To avoid having traces like "MismatchSSKey"="\\\\x15(\\\\x19\\\\x02\\\\xa2...

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@jzhou77 jzhou77 requested review from halfprice and xis19 April 4, 2023 04:16
@saintstack
Copy link
Contributor

saintstack commented Apr 4, 2023

Will this mean we have binary characters in the logs?

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Apr 4, 2023

Result of foundationdb-pr-clang-ide on Linux CentOS 7

  • Commit ID: 72ac6bc
  • Duration 0:15:09
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Apr 4, 2023

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

  • Commit ID: 72ac6bc
  • Duration 0:30:26
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Apr 4, 2023

Result of foundationdb-pr-macos on macOS Ventura 13.x

  • Commit ID: 72ac6bc
  • Duration 0:37:41
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Apr 4, 2023

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Apr 4, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 72ac6bc
  • Duration 0:45:13
  • Result: ❌ FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Apr 4, 2023

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 72ac6bc
  • Duration 0:55:00
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@jzhou77
Copy link
Contributor Author

jzhou77 commented Apr 4, 2023

Will this mean we have binary characters in the logs?

No. If you write .detail("Test", "\xff\x00\x01"_sr), the output in the trace is: Test="\xff\x00\x01", which is better than current output of using printable().

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Apr 4, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 72ac6bc
  • Duration 2:05:35
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@jzhou77 jzhou77 merged commit f17e466 into apple:main Apr 4, 2023
@jzhou77 jzhou77 mentioned this pull request Apr 4, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xis19 xis19 Awaiting requested review from xis19

1 more reviewer

@halfprice halfprice halfprice approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jzhou77 @saintstack @foundationdb-ci @fdb-windows-ci @halfprice