Skip to content

Changing single key deletions to delete based on number of deletes instead of bytelimit. #9882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jzhou77 merged 1 commit into from
Apr 4, 2023
Merged

Changing single key deletions to delete based on number of deletes instead of bytelimit. #9882

jzhou77 merged 1 commit into from
Apr 4, 2023

Conversation

@neethuhaneesha
Copy link
Contributor

@neethuhaneesha neethuhaneesha commented Apr 3, 2023

Changing single key deletions to delete based on number of deletes instead of bytelimit.
cherry-pick of #9867

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Apr 3, 2023

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

  • Commit ID: 6af1ee6
  • Duration 0:16:29
  • Result: ❌ FAILED
  • Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /opt/homebrew/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Apr 3, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 6af1ee6
  • Duration 0:35:06
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

jzhou77
jzhou77 approved these changes Apr 3, 2023
View reviewed changes
fdbserver/KeyValueStoreRocksDB.actor.cpp
std::unique_ptr<rocksdb::WriteBatch> writeBatch;
std::set<Key> keysSet;
// maximum number of single key deletes in a commit, if ROCKSDB_SINGLEKEY_DELETES_ON_CLEARRANGE is enabled.
int maxDeletes;
Copy link
Contributor

@jzhou77 jzhou77 Apr 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably cleaner that maxDeletes is part of WriteBatch, along with keysSet. This can be in another PR, though.

Copy link
Contributor Author

@neethuhaneesha neethuhaneesha Apr 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

writeBatch is a rocksdb structure. If needed, we can create a new structure including writeBatch, keysSet, maxDeletes.

Copy link
Contributor

@jzhou77 jzhou77 Apr 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. That's what I meant.

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Apr 3, 2023

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 6af1ee6
  • Duration 1:20:41
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Apr 3, 2023

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Apr 3, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 6af1ee6
  • Duration 2:35:07
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@jzhou77 jzhou77 merged commit d4e12f6 into apple:release-7.1 Apr 4, 2023
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Apr 4, 2023

Result of foundationdb-pr-macos on macOS Ventura 13.x

  • Commit ID: 6af1ee6
  • Duration 0:19:26
  • Result: ❌ FAILED
  • Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /usr/local/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Apr 4, 2023

Result of foundationdb-pr-macos on macOS Ventura 13.x

  • Commit ID: 6af1ee6
  • Duration 0:19:27
  • Result: ❌ FAILED
  • Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /usr/local/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@neethuhaneesha neethuhaneesha deleted the bytesample-7.1 branch April 4, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jzhou77 jzhou77 jzhou77 approved these changes

@xy-54321 xy-54321 Awaiting requested review from xy-54321

@saintstack saintstack Awaiting requested review from saintstack

+1 more reviewer

@liquid-helium liquid-helium liquid-helium approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@neethuhaneesha @foundationdb-ci @fdb-windows-ci @jzhou77 @liquid-helium