Skip to content

Changing single key deletions to delete based on number of deletes instead of bytelimit. #9867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
neethuhaneesha merged 1 commit into from
Apr 3, 2023
Merged

Changing single key deletions to delete based on number of deletes instead of bytelimit. #9867

neethuhaneesha merged 1 commit into from
Apr 3, 2023

Conversation

@neethuhaneesha
Copy link
Contributor

@neethuhaneesha neethuhaneesha commented Mar 31, 2023

Changing single key deletions to delete based on number of deletes instead of bytelimit.

Replace this text with your description here...

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@neethuhaneesha neethuhaneesha requested a review from xy-54321 March 31, 2023 21:45
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 31, 2023

Result of foundationdb-pr-clang-ide on Linux CentOS 7

  • Commit ID: 80ed68a
  • Duration 0:19:48
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

xy-54321
xy-54321 reviewed Mar 31, 2023
View reviewed changes
@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Mar 31, 2023

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 31, 2023

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 80ed68a
  • Duration 1:07:19
  • Result: ❌ FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 31, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 80ed68a
  • Duration 1:14:27
  • Result: ❌ FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 31, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 80ed68a
  • Duration 2:03:32
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Apr 3, 2023

Result of foundationdb-pr-clang-ide on Linux CentOS 7

  • Commit ID: 1e6c436
  • Duration 0:20:26
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Apr 3, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 1e6c436
  • Duration 0:38:00
  • Result: ❌ FAILED
  • Error: Error while executing command: docker build --label "org.foundationdb.version=${FDB_VERSION}" --label "org.foundationdb.build_date=${BUILD_DATE}" --label "org.foundationdb.commit=${COMMIT_SHA}" --progress plain --build-arg FDB_VERSION="${FDB_VERSION}" --build-arg FDB_LIBRARY_VERSIONS="${FDB_VERSION}" --build-arg FDB_WEBSITE="${FDB_WEBSITE}" --tag foundationdb/foundationdb-kubernetes-sidecar:${FDB_VERSION}-${COMMIT_SHA}-1 --file Dockerfile --target foundationdb-kubernetes-sidecar .. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@neethuhaneesha neethuhaneesha mentioned this pull request Apr 3, 2023
Merged
5 tasks
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Apr 3, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 1e6c436
  • Duration 1:11:29
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Apr 3, 2023

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Apr 3, 2023

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 1e6c436
  • Duration 1:24:45
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@neethuhaneesha neethuhaneesha merged commit 1d6908d into apple:main Apr 3, 2023
@neethuhaneesha neethuhaneesha deleted the bytesample branch April 3, 2023 20:56
@neethuhaneesha neethuhaneesha mentioned this pull request Apr 3, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xy-54321 xy-54321 Awaiting requested review from xy-54321

@saintstack saintstack Awaiting requested review from saintstack

1 more reviewer

@liquid-helium liquid-helium liquid-helium approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@neethuhaneesha @foundationdb-ci @fdb-windows-ci @liquid-helium @xy-54321