Skip to content

Fix ctest errors after 7.2.5 release #9866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jzhou77 merged 1 commit into from
Mar 31, 2023
Merged

Fix ctest errors after 7.2.5 release #9866

jzhou77 merged 1 commit into from
Mar 31, 2023

Conversation

@jzhou77
Copy link
Contributor

@jzhou77 jzhou77 commented Mar 31, 2023

By setting the latest version to 7.2.6

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@jzhou77
Fix ctest errors after 7.2.5 release
696c582 
By setting the latest version to 7.2.6
@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Mar 31, 2023

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 31, 2023

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 696c582
  • Duration 0:30:37
  • Result: ❌ FAILED
  • Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 31, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 696c582
  • Duration 1:11:18
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@flowguru
Copy link
Contributor

flowguru commented Mar 31, 2023 •
edited
Loading

its still failing, for instance single_process_fdbcli_tests , multi_process_fdbcli_tests, and fdb_c_unit_tests, they fail for the same reason.

@flowguru
Copy link
Contributor

flowguru commented Mar 31, 2023 

Traceback (most recent call last):
  File "/codebuild/output/src901673672/src/github.com/apple/foundationdb/tests/TestRunner/tmp_cluster.py", line 223, in <module>
    print(f.read())
  File "/codebuild/output/src901673672/src/github.com/apple/foundationdb/tests/TestRunner/tmp_cluster.py", line 59, in __exit__
    shutil.rmtree(self.tmp_dir)
  File "/opt/rh/rh-python38/root/usr/lib64/python3.8/shutil.py", line 718, in rmtree
    _rmtree_safe_fd(fd, path, onerror)
  File "/opt/rh/rh-python38/root/usr/lib64/python3.8/shutil.py", line 655, in _rmtree_safe_fd
    _rmtree_safe_fd(dirfd, fullname, onerror)
  File "/opt/rh/rh-python38/root/usr/lib64/python3.8/shutil.py", line 675, in _rmtree_safe_fd
    onerror(os.unlink, fullname, sys.exc_info())
  File "/opt/rh/rh-python38/root/usr/lib64/python3.8/shutil.py", line 673, in _rmtree_safe_fd
    os.unlink(entry.name, dir_fd=topfd)
FileNotFoundError: [Errno 2] No such file or directory: 'fdbmonitor.lock'

flowguru
flowguru approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@flowguru flowguru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed offline, the error is for another issue, will fix in another PR

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 31, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 696c582
  • Duration 2:04:05
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@jzhou77 jzhou77 merged commit fc87c16 into apple:release-7.2 Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neethuhaneesha neethuhaneesha neethuhaneesha approved these changes

@ammolitor ammolitor Awaiting requested review from ammolitor

+1 more reviewer

@flowguru flowguru flowguru approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jzhou77 @fdb-windows-ci @foundationdb-ci @flowguru @neethuhaneesha