Skip to content

Fix finishedQueries metric, add metrics reporting in GetMappedRange t… #9861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jzhou77 merged 4 commits into from
Apr 17, 2023
Merged

Fix finishedQueries metric, add metrics reporting in GetMappedRange t… #9861

jzhou77 merged 4 commits into from
Apr 17, 2023

Conversation

@flowguru
Copy link
Contributor

@flowguru flowguru commented Mar 31, 2023 •
edited
Loading

…… (release-7.2)

Replace this text with your description here...

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@flowguru
Fix finishedQueries metric, add metrics reporting in GetMappedRange t… (
b0495c3 
apple#9796)

* Fix finishedQueries metric, add metrics reporting in GetMappedRange test [release-7.1] (apple#9785)

* Fix finishedQueries metric, add metrics reporting in GetMappedRange test

* refactor to make format work

* resolve comments

* Fix more comments

* Fix bugs and change running time of test

* use double for options
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 31, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: b0495c3
  • Duration 0:21:03
  • Result: ❌ FAILED
  • Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Mar 31, 2023

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 31, 2023

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

  • Commit ID: b0495c3
  • Duration 0:25:43
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 31, 2023

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: b0495c3
  • Duration 0:28:29
  • Result: ❌ FAILED
  • Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 31, 2023

Result of foundationdb-pr-macos on macOS Ventura 13.x

  • Commit ID: b0495c3
  • Duration 0:33:34
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 31, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: b0495c3
  • Duration 2:00:51
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Apr 2, 2023

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

  • Commit ID: 59a20d3
  • Duration 0:25:54
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Apr 2, 2023

Result of foundationdb-pr-macos on macOS Ventura 13.x

  • Commit ID: 59a20d3
  • Duration 0:33:19
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Apr 2, 2023

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Apr 2, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 59a20d3
  • Duration 2:08:34
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Apr 2, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 59a20d3
  • Duration 3:00:29
  • Result: ❌ FAILED
  • Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Apr 2, 2023

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 59a20d3
  • Duration 3:00:35
  • Result: ❌ FAILED
  • Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Apr 4, 2023

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Apr 4, 2023

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

  • Commit ID: 8dde149
  • Duration 0:25:46
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Apr 4, 2023

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 8dde149
  • Duration 0:30:48
  • Result: ❌ FAILED
  • Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Apr 4, 2023

Result of foundationdb-pr-macos on macOS Ventura 13.x

  • Commit ID: 8dde149
  • Duration 0:34:34
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@flowguru
Copy link
Contributor Author

flowguru commented Apr 4, 2023

2 tests failed for the same reason. It should applies to all PR against release-7.2 branch.

95% tests passed, 2 tests failed out of 38

  File "/codebuild/output/src827839778/src/github.com/apple/foundationdb/tests/TestRunner/tmp_cluster.py", line 223, in <module>
    print(f.read())
  File "/codebuild/output/src827839778/src/github.com/apple/foundationdb/tests/TestRunner/tmp_cluster.py", line 59, in __exit__
    shutil.rmtree(self.tmp_dir)
  File "/opt/rh/rh-python38/root/usr/lib64/python3.8/shutil.py", line 718, in rmtree
    _rmtree_safe_fd(fd, path, onerror)
  File "/opt/rh/rh-python38/root/usr/lib64/python3.8/shutil.py", line 655, in _rmtree_safe_fd
    _rmtree_safe_fd(dirfd, fullname, onerror)
  File "/opt/rh/rh-python38/root/usr/lib64/python3.8/shutil.py", line 675, in _rmtree_safe_fd
    onerror(os.unlink, fullname, sys.exc_info())
  File "/opt/rh/rh-python38/root/usr/lib64/python3.8/shutil.py", line 673, in _rmtree_safe_fd
    os.unlink(entry.name, dir_fd=topfd)
FileNotFoundError: [Errno 2] No such file or directory: 'fdbmonitor.lock'

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Apr 4, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 8dde149
  • Duration 2:00:56
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Apr 4, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 8dde149
  • Duration 3:00:38
  • Result: ❌ FAILED
  • Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Apr 17, 2023

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Apr 17, 2023

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 8a8ca89
  • Duration 0:33:07
  • Result: ❌ FAILED
  • Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Apr 17, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 8a8ca89
  • Duration 0:58:37
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Apr 17, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 8a8ca89
  • Duration 1:25:36
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@jzhou77 jzhou77 merged commit a691dad into apple:release-7.2 Apr 17, 2023
@flowguru flowguru deleted the p72 branch April 17, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jzhou77 jzhou77 jzhou77 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@flowguru @foundationdb-ci @fdb-windows-ci @jzhou77