Skip to content

Log background error and add knobs for memory tuning. #9841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jzhou77 merged 4 commits into from
Apr 6, 2023
Merged

Log background error and add knobs for memory tuning. #9841

jzhou77 merged 4 commits into from
Apr 6, 2023

Conversation

@xy-54321
Copy link
Contributor

@xy-54321 xy-54321 commented Mar 29, 2023

Replace this text with your description here...

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 29, 2023

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 2507026
  • Duration 0:04:30
  • Result: ❌ FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 29, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 2507026
  • Duration 0:04:35
  • Result: ❌ FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 29, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 2507026
  • Duration 0:04:37
  • Result: ❌ FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 29, 2023

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

  • Commit ID: 2507026
  • Duration 0:05:32
  • Result: ❌ FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 29, 2023

Result of foundationdb-pr-macos on macOS Ventura 13.x

  • Commit ID: 2507026
  • Duration 0:06:06
  • Result: ❌ FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Mar 29, 2023

Doxense CI Report for Windows 10

@xy-54321 xy-54321 changed the title Log background error and add knob for recovery mode. Log background error and add knobs for memory tuning. Apr 4, 2023
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Apr 4, 2023

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 6e9f1ce
  • Duration 0:08:41
  • Result: ❌ FAILED
  • Error: reference not found for primary source and source version 6e9f1ce06581412ee2526f039ff30c1d40adfa24
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Apr 4, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 6e9f1ce
  • Duration 0:08:44
  • Result: ❌ FAILED
  • Error: reference not found for primary source and source version 6e9f1ce06581412ee2526f039ff30c1d40adfa24
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Apr 4, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 6e9f1ce
  • Duration 0:08:57
  • Result: ❌ FAILED
  • Error: reference not found for primary source and source version 6e9f1ce06581412ee2526f039ff30c1d40adfa24
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Apr 4, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 69e74ab
  • Duration 0:25:04
  • Result: ❌ FAILED
  • Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Apr 4, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: b7684b2
  • Duration 0:26:15
  • Result: ❌ FAILED
  • Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Apr 4, 2023

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: b7684b2
  • Duration 0:37:30
  • Result: ❌ FAILED
  • Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Apr 4, 2023

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 69e74ab
  • Duration 0:38:27
  • Result: ❌ FAILED
  • Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Apr 4, 2023

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Apr 4, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 69e74ab
  • Duration 2:05:33
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Apr 4, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: b7684b2
  • Duration 2:05:51
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Apr 4, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: d3210f7
  • Duration 0:43:49
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Apr 4, 2023

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Apr 4, 2023

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: d3210f7
  • Duration 0:55:24
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Apr 4, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: d3210f7
  • Duration 1:21:23
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@jzhou77 jzhou77 merged commit 7799995 into apple:release-7.2 Apr 6, 2023
@xy-54321 xy-54321 deleted the wal-fix branch April 11, 2023 18:57
xy-54321 pushed a commit to xy-54321/foundationdb that referenced this pull request May 4, 2023
Log background error and add knobs for memory tuning. (apple#9841)
c85e06a 
* error logger

* recovery mode
xy-54321 pushed a commit to xy-54321/foundationdb that referenced this pull request May 9, 2023
Log background error and add knobs for memory tuning. (apple#9841)
6c47778 
* error logger

* recovery mode
xy-54321 pushed a commit to xy-54321/foundationdb that referenced this pull request May 10, 2023
Log background error and add knobs for memory tuning. (apple#9841)
60d91ce 
* error logger

* recovery mode
xy-54321 pushed a commit to xy-54321/foundationdb that referenced this pull request May 10, 2023
Log background error and add knobs for memory tuning. (apple#9841)
fa101e1 
* error logger

* recovery mode
xy-54321 pushed a commit to xy-54321/foundationdb that referenced this pull request May 10, 2023
Log background error and add knobs for memory tuning. (apple#9841)
ee0655e 
* error logger

* recovery mode
xy-54321 pushed a commit to xy-54321/foundationdb that referenced this pull request May 10, 2023
Log background error and add knobs for memory tuning. (apple#9841)
54ce596 
* error logger

* recovery mode
xy-54321 pushed a commit to xy-54321/foundationdb that referenced this pull request May 11, 2023
Log background error and add knobs for memory tuning. (apple#9841)
a317570 
* error logger

* recovery mode
xy-54321 added a commit that referenced this pull request May 11, 2023
@xy-54321
[release-7.3] Cherrypick Sharded RocksDB fixes. (#10203)
df370e3 
* Cherrypick #9665

* Cherrypick #9746

* Log background error and add knobs for memory tuning. (#9841)

* error logger

* recovery mode

* Range deletion memory usage improvements  (#10048)

* Fix build error.

* initialize counter

* Log physical shard size in KVS

* fix build error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neethuhaneesha neethuhaneesha neethuhaneesha approved these changes

@saintstack saintstack Awaiting requested review from saintstack

@jzhou77 jzhou77 Awaiting requested review from jzhou77

+1 more reviewer

@liquid-helium liquid-helium liquid-helium approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@xy-54321 @foundationdb-ci @fdb-windows-ci @neethuhaneesha @liquid-helium @jzhou77