Skip to content

Do not update exclude/failed system metadata in excludeServers if the input list is already excluded/failed. #9803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
halfprice merged 7 commits into from
Mar 27, 2023
Merged

Do not update exclude/failed system metadata in excludeServers if the input list is already excluded/failed. #9803

halfprice merged 7 commits into from
Mar 27, 2023

Conversation

@halfprice
Copy link
Contributor

@halfprice halfprice commented Mar 24, 2023 •
edited
Loading

The motivation is that exclude command triggers recovery if the system is not in fully_recovered state. This causes trouble during unstable states.

20230325-031637-zhewu_exclude-a96cf27b7a08a2db compressed=True data_size=32586002 duration=4731216 ended=100000 fail=4 fail_fast=10 max_runs=100000 pass=99996 priority=100 remaining=0 runtime=1:02:28 sanity=False started=100000 stopped=20230325-041905 submitted=20230325-031637 timeout=5400 username=zhewu_exclude

All unrealted failures.

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Mar 24, 2023

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 24, 2023

Result of foundationdb-pr-clang-ide on Linux CentOS 7

  • Commit ID: 18f03ba
  • Duration 0:15:36
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 24, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 18f03ba
  • Duration 0:23:29
  • Result: ❌ FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Mar 24, 2023

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 24, 2023

Result of foundationdb-pr-clang-ide on Linux CentOS 7

  • Commit ID: 6e1bb08
  • Duration 0:14:38
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 24, 2023

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 18f03ba
  • Duration 0:34:32
  • Result: ❌ FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 24, 2023

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

  • Commit ID: 6e1bb08
  • Duration 0:28:29
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 24, 2023

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 6e1bb08
  • Duration 0:51:55
  • Result: ❌ FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 24, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 6e1bb08
  • Duration 0:52:18
  • Result: ❌ FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 24, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 18f03ba
  • Duration 1:19:14
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 24, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 6e1bb08
  • Duration 1:20:31
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Mar 25, 2023

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 25, 2023

Result of foundationdb-pr-clang-ide on Linux CentOS 7

  • Commit ID: a278e72
  • Duration 0:14:26
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 25, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: a278e72
  • Duration 0:40:01
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 25, 2023

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: a278e72
  • Duration 0:45:05
  • Result: ❌ FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 25, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: a278e72
  • Duration 1:21:19
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Mar 25, 2023

Doxense CI Report for Windows 10

@halfprice halfprice marked this pull request as ready for review March 25, 2023 03:26
@halfprice halfprice requested review from johscheuer and jzhou77 March 25, 2023 03:26
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 25, 2023

Result of foundationdb-pr-clang-ide on Linux CentOS 7

  • Commit ID: b454896
  • Duration 0:14:59
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 25, 2023

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

  • Commit ID: b454896
  • Duration 0:29:59
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 25, 2023

Result of foundationdb-pr-macos on macOS Ventura 13.x

  • Commit ID: b454896
  • Duration 0:37:43
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 25, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: b454896
  • Duration 0:47:18
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 25, 2023

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: b454896
  • Duration 0:47:28
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 25, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: b454896
  • Duration 1:16:42
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

johscheuer
johscheuer approved these changes Mar 25, 2023
View reviewed changes
Copy link
Contributor

@johscheuer johscheuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM 👍

fdbclient/ManagementAPI.actor.cpp
tr->addReadConflictRange(singleKeyRange(serversVersionKey)); // To conflict with parallel includeServers
tr->set(serversVersionKey, excludeVersionKey);
}
TraceEvent("ExcludeServersCommit")
Copy link
Contributor

@johscheuer johscheuer Mar 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a trace event to include the excludeVersionKey?

Copy link
Contributor Author

@halfprice halfprice Mar 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SG. I'll add one later since CI has all passed in this PR now..

jzhou77
jzhou77 approved these changes Mar 26, 2023
View reviewed changes
Copy link
Contributor

@jzhou77 jzhou77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@halfprice halfprice merged commit 4a7f7cd into apple:main Mar 27, 2023
@halfprice halfprice deleted the zhewu/exclude-check-existance branch March 27, 2023 16:38
@halfprice halfprice mentioned this pull request Mar 27, 2023
Merged
5 tasks
@jzhou77 jzhou77 mentioned this pull request Mar 28, 2023
Merged
5 tasks
@halfprice halfprice mentioned this pull request Apr 2, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johscheuer johscheuer johscheuer approved these changes

@jzhou77 jzhou77 jzhou77 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@halfprice @fdb-windows-ci @foundationdb-ci @johscheuer @jzhou77