Fix finishedQueries metric, add metrics reporting in GetMappedRange t… #9796

flowguru · 2023-03-23T22:37:03Z

…est (#9785)

this PR includes #9785 and #9808
20230327-151859-haofu-c00466a3a157e11b

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

The PR has a description, explaining both the problem and the solution.
The description mentions which forms of testing were done and the testing seems reasonable.
Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

fdb-windows-ci · 2023-03-23T22:42:58Z

Doxense CI Report for Windows 10

Commit ID: f50106c
Result: ❌ FAILED
Build Logs (available for 30 days)

foundationdb-ci · 2023-03-23T22:55:21Z

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: f50106c
Duration 0:18:08
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-03-23T23:22:02Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: f50106c
Duration 0:44:49
Result: ❌ FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-03-23T23:32:37Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: f50106c
Duration 0:55:25
Result: ❌ FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-03-23T23:58:50Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: f50106c
Duration 1:21:39
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

fdb-windows-ci · 2023-03-27T15:22:54Z

Doxense CI Report for Windows 10

Commit ID: a45ca44
Result: ❌ FAILED
Build Logs (available for 30 days)

foundationdb-ci · 2023-03-27T15:23:03Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: a45ca44
Duration 0:04:21
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-03-27T15:23:03Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: a45ca44
Duration 0:04:23
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2023-03-27T15:23:08Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: a45ca44
Duration 0:04:26
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-03-27T15:23:09Z

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: a45ca44
Duration 0:04:27
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

…est [release-7.1] (apple#9785) * Fix finishedQueries metric, add metrics reporting in GetMappedRange test * refactor to make format work * resolve comments * Fix more comments * Fix bugs and change running time of test

fdb-windows-ci · 2023-03-27T15:43:11Z

Doxense CI Report for Windows 10

Commit ID: 8f20ca5
Result: ❌ FAILED
Build Logs (available for 30 days)

foundationdb-ci · 2023-03-27T15:44:11Z

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: 8f20ca5
Duration 0:14:43
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-03-27T15:51:17Z

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: 8f20ca5
Duration 0:21:49
Result: ❌ FAILED
Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /opt/homebrew/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-03-27T16:13:48Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 8f20ca5
Duration 0:44:21
Result: ❌ FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

jzhou77 · 2023-03-27T16:14:10Z

fdbserver/workloads/GetMappedRange.actor.cpp

+	int checkStorageQueueSeconds;
+	int queueMaxLength;


Can you change both to double?

M1 CI found an error because of this:

GetMappedRange.actor.g.cpp In file included from /Users/ec2-user/foundationdb/fdbserver/workloads/GetMappedRange.actor.cpp:22: In file included from /Users/ec2-user/foundationdb/fdbclient/include/fdbclient/MutationLogReader.actor.h:25: In file included from /Users/ec2-user/foundationdb/fdbclient/include/fdbclient/MutationLogReader.actor.h:30: In file included from /Users/ec2-user/foundationdb/fdbclient/include/fdbclient/FDBTypes.h:35: In file included from /Users/ec2-user/foundationdb/fdbclient/include/fdbclient/Status.h:24: In file included from /Users/ec2-user/foundationdb/fdbclient/include/fdbclient/JSONDoc.h:23: In file included from /Users/ec2-user/foundationdb/fdbclient/include/fdbclient/json_spirit/json_spirit_writer_template.h:13: /Users/ec2-user/foundationdb/fdbclient/include/fdbclient/json_spirit/json_spirit_value.h:485:9: error: no matching function for call to 'get_value' return internal_::get_value(*this, internal_::Type_to_type<T>()); ^~~~~~~~~~~~~~~~~~~~ /Users/ec2-user/foundationdb/fdbclient/include/fdbclient/JSONDoc.h:268:17: note: in instantiation of function template specialization 'json_spirit::Value_impl<json_spirit::Config_map<std::string>>::get_value<long>' requested here out = pLast->get_value<T>(); ^ /Users/ec2-user/foundationdb/fdbserver/workloads/GetMappedRange.actor.cpp:484:12: note: in instantiation of function template specialization 'JSONDoc::get<long>' requested here role.get("query_queue_max", queryQueueMax); ^ /Users/ec2-user/foundationdb_build_output_macos_arm64/fdbserver/workloads/GetMappedRange.actor.g.cpp:3399:16: note: in instantiation of member function 'GetMappedRangeWorkload::ReportMetricActorState<GetMappedRangeWorkload::ReportMetricActor>::a_body1loopBody1cont5' requested here loopDepth = a_body1loopBody1cont5(loopDepth); ^ /Users/ec2-user/foundationdb_build_output_macos_arm64/fdbserver/workloads/GetMappedRange.actor.g.cpp:3272:16: note: in instantiation of member function 'GetMappedRangeWorkload::ReportMetricActorState<GetMappedRangeWorkload::ReportMetricActor>::a_body1loopBody1cont2' requested here loopDepth = a_body1loopBody1cont2(loopDepth); ^ /Users/ec2-user/foundationdb_build_output_macos_arm64/fdbserver/workloads/GetMappedRange.actor.g.cpp:3316:15: note: in instantiation of member function 'GetMappedRangeWorkload::ReportMetricActorState<GetMappedRangeWorkload::ReportMetricActor>::a_body1loopBody1cont1' requested here loopDepth = a_body1loopBody1cont1(result, loopDepth); ^ /Users/ec2-user/foundationdb_build_output_macos_arm64/fdbserver/workloads/GetMappedRange.actor.g.cpp:3231:151: note: in instantiation of member function 'GetMappedRangeWorkload::ReportMetricActorState<GetMappedRangeWorkload::ReportMetricActor>::a_body1loopBody1when1' requested here if (__when_expr_0.isReady()) { if (__when_expr_0.isError()) return a_body1Catch1(__when_expr_0.getError(), std::max(0, loopDepth - 1)); else return a_body1loopBody1when1(__when_expr_0.get(), loopDepth); }; ^ /Users/ec2-user/foundationdb_build_output_macos_arm64/fdbserver/workloads/GetMappedRange.actor.g.cpp:3220:49: note: in instantiation of member function 'GetMappedRangeWorkload::ReportMetricActorState<GetMappedRangeWorkload::ReportMetricActor>::a_body1loopBody1' requested here while (loopDepth == oldLoopDepth) loopDepth = a_body1loopBody1(loopDepth); ^ /Users/ec2-user/foundationdb_build_output_macos_arm64/fdbserver/workloads/GetMappedRange.actor.g.cpp:3199:16: note: in instantiation of member function 'GetMappedRangeWorkload::ReportMetricActorState<GetMappedRangeWorkload::ReportMetricActor>::a_body1loopHead1' requested here loopDepth = a_body1loopHead1(loopDepth); ^ /Users/ec2-user/foundationdb_build_output_macos_arm64/fdbserver/workloads/GetMappedRange.actor.g.cpp:3720:9: note: in instantiation of member function 'GetMappedRangeWorkload::ReportMetricActorState<GetMappedRangeWorkload::ReportMetricActor>::a_body1' requested here this->a_body1(); ^ /Users/ec2-user/foundationdb/fdbclient/include/fdbclient/json_spirit/json_spirit_value.h:442:5: note: candidate function template not viable: no known conversion from 'Type_to_type<long>' to 'Type_to_type<int>' for 2nd argument int get_value(const Value& value, Type_to_type<int>) { ^ /Users/ec2-user/foundationdb/fdbclient/include/fdbclient/json_spirit/json_spirit_value.h:447:9: note: candidate function template not viable: no known conversion from 'Type_to_type<long>' to 'Type_to_type<int64_t>' for 2nd argument int64_t get_value(const Value& value, Type_to_type<int64_t>) { ^ /Users/ec2-user/foundationdb/fdbclient/include/fdbclient/json_spirit/json_spirit_value.h:452:10: note: candidate function template not viable: no known conversion from 'Type_to_type<long>' to 'Type_to_type<uint64_t>' for 2nd argument uint64_t get_value(const Value& value, Type_to_type<uint64_t>) { ^ /Users/ec2-user/foundationdb/fdbclient/include/fdbclient/json_spirit/json_spirit_value.h:457:8: note: candidate function template not viable: no known conversion from 'Type_to_type<long>' to 'Type_to_type<double>' for 2nd argument double get_value(const Value& value, Type_to_type<double>) { ^ /Users/ec2-user/foundationdb/fdbclient/include/fdbclient/json_spirit/json_spirit_value.h:462:29: note: candidate function [with Value = json_spirit::Value_impl<json_spirit::Config_map<std::string>>] not viable: no known conversion from 'Type_to_type<long>' to 'Type_to_type<typename Value_impl<Config_map<string>>::String_type>' for 2nd argument typename Value::String_type get_value(const Value& value, Type_to_type<typename Value::String_type>) { ^ /Users/ec2-user/foundationdb/fdbclient/include/fdbclient/json_spirit/json_spirit_value.h:467:23: note: candidate function [with Value = json_spirit::Value_impl<json_spirit::Config_map<std::string>>] not viable: no known conversion from 'Type_to_type<long>' to 'Type_to_type<typename Value_impl<Config_map<string>>::Array>' for 2nd argument typename Value::Array get_value(const Value& value, Type_to_type<typename Value::Array>) { ^ /Users/ec2-user/foundationdb/fdbclient/include/fdbclient/json_spirit/json_spirit_value.h:472:24: note: candidate function [with Value = json_spirit::Value_impl<json_spirit::Config_map<std::string>>] not viable: no known conversion from 'Type_to_type<long>' to 'Type_to_type<typename Value_impl<Config_map<string>>::Object>' for 2nd argument typename Value::Object get_value(const Value& value, Type_to_type<typename Value::Object>) { ^ /Users/ec2-user/foundationdb/fdbclient/include/fdbclient/json_spirit/json_spirit_value.h:477:6: note: candidate function template not viable: no known conversion from 'Type_to_type<long>' to 'Type_to_type<bool>' for 2nd argument bool get_value(const Value& value, Type_to_type<bool>) { ^ 1 error generated.

Can you change both to double?

M1 CI found an error because of this:

GetMappedRange.actor.g.cpp In file included from /Users/ec2-user/foundationdb/fdbserver/workloads/GetMappedRange.actor.cpp:22: In file included from /Users/ec2-user/foundationdb/fdbclient/include/fdbclient/MutationLogReader.actor.h:25: In file included from /Users/ec2-user/foundationdb/fdbclient/include/fdbclient/MutationLogReader.actor.h:30: In file included from /Users/ec2-user/foundationdb/fdbclient/include/fdbclient/FDBTypes.h:35: In file included from /Users/ec2-user/foundationdb/fdbclient/include/fdbclient/Status.h:24: In file included from /Users/ec2-user/foundationdb/fdbclient/include/fdbclient/JSONDoc.h:23: In file included from /Users/ec2-user/foundationdb/fdbclient/include/fdbclient/json_spirit/json_spirit_writer_template.h:13: /Users/ec2-user/foundationdb/fdbclient/include/fdbclient/json_spirit/json_spirit_value.h:485:9: error: no matching function for call to 'get_value' return internal_::get_value(*this, internal_::Type_to_type<T>()); ^~~~~~~~~~~~~~~~~~~~ /Users/ec2-user/foundationdb/fdbclient/include/fdbclient/JSONDoc.h:268:17: note: in instantiation of function template specialization 'json_spirit::Value_impl<json_spirit::Config_map<std::string>>::get_value<long>' requested here out = pLast->get_value<T>(); ^ /Users/ec2-user/foundationdb/fdbserver/workloads/GetMappedRange.actor.cpp:484:12: note: in instantiation of function template specialization 'JSONDoc::get<long>' requested here role.get("query_queue_max", queryQueueMax); ^ /Users/ec2-user/foundationdb_build_output_macos_arm64/fdbserver/workloads/GetMappedRange.actor.g.cpp:3399:16: note: in instantiation of member function 'GetMappedRangeWorkload::ReportMetricActorState<GetMappedRangeWorkload::ReportMetricActor>::a_body1loopBody1cont5' requested here loopDepth = a_body1loopBody1cont5(loopDepth); ^ /Users/ec2-user/foundationdb_build_output_macos_arm64/fdbserver/workloads/GetMappedRange.actor.g.cpp:3272:16: note: in instantiation of member function 'GetMappedRangeWorkload::ReportMetricActorState<GetMappedRangeWorkload::ReportMetricActor>::a_body1loopBody1cont2' requested here loopDepth = a_body1loopBody1cont2(loopDepth); ^ /Users/ec2-user/foundationdb_build_output_macos_arm64/fdbserver/workloads/GetMappedRange.actor.g.cpp:3316:15: note: in instantiation of member function 'GetMappedRangeWorkload::ReportMetricActorState<GetMappedRangeWorkload::ReportMetricActor>::a_body1loopBody1cont1' requested here loopDepth = a_body1loopBody1cont1(result, loopDepth); ^ /Users/ec2-user/foundationdb_build_output_macos_arm64/fdbserver/workloads/GetMappedRange.actor.g.cpp:3231:151: note: in instantiation of member function 'GetMappedRangeWorkload::ReportMetricActorState<GetMappedRangeWorkload::ReportMetricActor>::a_body1loopBody1when1' requested here if (__when_expr_0.isReady()) { if (__when_expr_0.isError()) return a_body1Catch1(__when_expr_0.getError(), std::max(0, loopDepth - 1)); else return a_body1loopBody1when1(__when_expr_0.get(), loopDepth); }; ^ /Users/ec2-user/foundationdb_build_output_macos_arm64/fdbserver/workloads/GetMappedRange.actor.g.cpp:3220:49: note: in instantiation of member function 'GetMappedRangeWorkload::ReportMetricActorState<GetMappedRangeWorkload::ReportMetricActor>::a_body1loopBody1' requested here while (loopDepth == oldLoopDepth) loopDepth = a_body1loopBody1(loopDepth); ^ /Users/ec2-user/foundationdb_build_output_macos_arm64/fdbserver/workloads/GetMappedRange.actor.g.cpp:3199:16: note: in instantiation of member function 'GetMappedRangeWorkload::ReportMetricActorState<GetMappedRangeWorkload::ReportMetricActor>::a_body1loopHead1' requested here loopDepth = a_body1loopHead1(loopDepth); ^ /Users/ec2-user/foundationdb_build_output_macos_arm64/fdbserver/workloads/GetMappedRange.actor.g.cpp:3720:9: note: in instantiation of member function 'GetMappedRangeWorkload::ReportMetricActorState<GetMappedRangeWorkload::ReportMetricActor>::a_body1' requested here this->a_body1(); ^ /Users/ec2-user/foundationdb/fdbclient/include/fdbclient/json_spirit/json_spirit_value.h:442:5: note: candidate function template not viable: no known conversion from 'Type_to_type<long>' to 'Type_to_type<int>' for 2nd argument int get_value(const Value& value, Type_to_type<int>) { ^ /Users/ec2-user/foundationdb/fdbclient/include/fdbclient/json_spirit/json_spirit_value.h:447:9: note: candidate function template not viable: no known conversion from 'Type_to_type<long>' to 'Type_to_type<int64_t>' for 2nd argument int64_t get_value(const Value& value, Type_to_type<int64_t>) { ^ /Users/ec2-user/foundationdb/fdbclient/include/fdbclient/json_spirit/json_spirit_value.h:452:10: note: candidate function template not viable: no known conversion from 'Type_to_type<long>' to 'Type_to_type<uint64_t>' for 2nd argument uint64_t get_value(const Value& value, Type_to_type<uint64_t>) { ^ /Users/ec2-user/foundationdb/fdbclient/include/fdbclient/json_spirit/json_spirit_value.h:457:8: note: candidate function template not viable: no known conversion from 'Type_to_type<long>' to 'Type_to_type<double>' for 2nd argument double get_value(const Value& value, Type_to_type<double>) { ^ /Users/ec2-user/foundationdb/fdbclient/include/fdbclient/json_spirit/json_spirit_value.h:462:29: note: candidate function [with Value = json_spirit::Value_impl<json_spirit::Config_map<std::string>>] not viable: no known conversion from 'Type_to_type<long>' to 'Type_to_type<typename Value_impl<Config_map<string>>::String_type>' for 2nd argument typename Value::String_type get_value(const Value& value, Type_to_type<typename Value::String_type>) { ^ /Users/ec2-user/foundationdb/fdbclient/include/fdbclient/json_spirit/json_spirit_value.h:467:23: note: candidate function [with Value = json_spirit::Value_impl<json_spirit::Config_map<std::string>>] not viable: no known conversion from 'Type_to_type<long>' to 'Type_to_type<typename Value_impl<Config_map<string>>::Array>' for 2nd argument typename Value::Array get_value(const Value& value, Type_to_type<typename Value::Array>) { ^ /Users/ec2-user/foundationdb/fdbclient/include/fdbclient/json_spirit/json_spirit_value.h:472:24: note: candidate function [with Value = json_spirit::Value_impl<json_spirit::Config_map<std::string>>] not viable: no known conversion from 'Type_to_type<long>' to 'Type_to_type<typename Value_impl<Config_map<string>>::Object>' for 2nd argument typename Value::Object get_value(const Value& value, Type_to_type<typename Value::Object>) { ^ /Users/ec2-user/foundationdb/fdbclient/include/fdbclient/json_spirit/json_spirit_value.h:477:6: note: candidate function template not viable: no known conversion from 'Type_to_type<long>' to 'Type_to_type<bool>' for 2nd argument bool get_value(const Value& value, Type_to_type<bool>) { ^ 1 error generated.

it seems the issue is at line role.get("query_queue_max", queryQueueMax);, but I can change them both to double after fixing the issue anyway

foundationdb-ci · 2023-03-27T16:29:13Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: 8f20ca5
Duration 0:59:44
Result: ❌ FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-03-27T16:48:08Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 8f20ca5
Duration 1:18:40
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2023-03-27T17:09:03Z

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: eca6082
Duration 0:15:22
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

fdb-windows-ci · 2023-03-27T17:14:04Z

Doxense CI Report for Windows 10

Commit ID: eca6082
Result: ❌ FAILED
Build Logs (available for 30 days)

foundationdb-ci · 2023-03-27T17:47:05Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: eca6082
Duration 0:53:23
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-03-27T17:47:35Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: eca6082
Duration 0:53:50
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-03-27T18:17:18Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: eca6082
Duration 1:23:37
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2023-03-27T20:45:08Z

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: eca6082
Duration 0:28:02
Result: ❌ FAILED
Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /usr/local/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-03-27T21:10:41Z

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: a9a1c1f
Duration 0:15:05
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-03-27T21:23:38Z

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: a9a1c1f
Duration 0:27:58
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-03-27T21:33:08Z

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: a9a1c1f
Duration 0:37:27
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-03-27T21:33:34Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: a9a1c1f
Duration 0:37:52
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-03-27T21:45:48Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: a9a1c1f
Duration 0:50:08
Result: ❌ FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

flowguru · 2023-03-27T21:47:58Z

 TestFile="tests/fast/ValidateStorage.toml"

not related

foundationdb-ci · 2023-03-27T22:16:18Z

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: a9a1c1f
Duration 0:28:29
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-03-27T22:20:27Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: a9a1c1f
Duration 1:24:50
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2023-03-27T22:32:37Z

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: a9a1c1f
Duration 0:44:50
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-03-27T23:15:38Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: a9a1c1f
Duration 1:27:48
Result: ❌ FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-03-27T23:36:59Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: a9a1c1f
Duration 1:49:08
Result: ❌ FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-03-27T23:37:59Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: a9a1c1f
Duration 1:50:13
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2023-03-28T00:25:48Z

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: a9a1c1f
Duration 0:14:36
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-03-28T00:39:44Z

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: a9a1c1f
Duration 0:28:32
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

flowguru · 2023-03-28T00:40:50Z

TestFile="tests/fast/PhysicalShardMove.toml"
TestFile="tests/slow/ParallelRestoreNewBackupCorrectnessAtomicOp.toml"
TestFile="tests/restarting/from_7.3.0/DrUpgradeRestart-1.toml"
TestFile="tests/restarting/from_7.3.0/DrUpgradeRestart-2.toml"

all not related

foundationdb-ci · 2023-03-28T00:49:28Z

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: a9a1c1f
Duration 0:38:16
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-03-28T00:59:38Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: a9a1c1f
Duration 0:48:27
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-03-28T01:16:29Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: a9a1c1f
Duration 1:05:19
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-03-28T01:29:27Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: a9a1c1f
Duration 1:18:16
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

apple#9796) * Fix finishedQueries metric, add metrics reporting in GetMappedRange test [release-7.1] (apple#9785) * Fix finishedQueries metric, add metrics reporting in GetMappedRange test * refactor to make format work * resolve comments * Fix more comments * Fix bugs and change running time of test * use double for options

#9796) (#9861) * Fix finishedQueries metric, add metrics reporting in GetMappedRange test [release-7.1] (#9785) * Fix finishedQueries metric, add metrics reporting in GetMappedRange test * refactor to make format work * resolve comments * Fix more comments * Fix bugs and change running time of test * use double for options

flowguru added the in progress Use this for tasks you are actively working on label Mar 24, 2023

flowguru force-pushed the fixm branch from f50106c to a45ca44 Compare March 27, 2023 15:18

flowguru force-pushed the fixm branch from a45ca44 to 8f20ca5 Compare March 27, 2023 15:29

flowguru requested a review from jzhou77 March 27, 2023 15:49

jzhou77 previously approved these changes Mar 27, 2023

View reviewed changes

jzhou77 reviewed Mar 27, 2023

View reviewed changes

flowguru dismissed jzhou77’s stale review via eca6082 March 27, 2023 16:53

flowguru closed this Mar 27, 2023

flowguru reopened this Mar 27, 2023

jzhou77 approved these changes Mar 27, 2023

View reviewed changes

flowguru closed this Mar 28, 2023

flowguru reopened this Mar 28, 2023

flowguru merged commit b205862 into apple:main Mar 28, 2023

flowguru mentioned this pull request Mar 28, 2023

Parameterized queue length in GetMappedRange test(release-7.1) #9808

Merged

5 tasks

flowguru mentioned this pull request Mar 31, 2023

Fix finishedQueries metric, add metrics reporting in GetMappedRange t… #9861

Merged

5 tasks

flowguru deleted the fixm branch January 10, 2024 02:22

Fix finishedQueries metric, add metrics reporting in GetMappedRange t… #9796

Fix finishedQueries metric, add metrics reporting in GetMappedRange t… #9796

Uh oh!

Conversation

flowguru commented Mar 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code-Reviewer Section

For Release-Branches

Uh oh!

fdb-windows-ci commented Mar 23, 2023

Doxense CI Report for Windows 10

Uh oh!

foundationdb-ci commented Mar 23, 2023

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Uh oh!

foundationdb-ci commented Mar 23, 2023

Result of foundationdb-pr on Linux CentOS 7

Uh oh!

foundationdb-ci commented Mar 23, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

Uh oh!

foundationdb-ci commented Mar 23, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Uh oh!

fdb-windows-ci commented Mar 27, 2023

Doxense CI Report for Windows 10

Uh oh!

foundationdb-ci commented Mar 27, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

Uh oh!

foundationdb-ci commented Mar 27, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Uh oh!

foundationdb-ci commented Mar 27, 2023

Result of foundationdb-pr on Linux CentOS 7

Uh oh!

foundationdb-ci commented Mar 27, 2023

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Uh oh!

fdb-windows-ci commented Mar 27, 2023

Doxense CI Report for Windows 10

Uh oh!

foundationdb-ci commented Mar 27, 2023

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Uh oh!

foundationdb-ci commented Mar 27, 2023

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Uh oh!

foundationdb-ci commented Mar 27, 2023

Result of foundationdb-pr on Linux CentOS 7

Uh oh!

jzhou77 Mar 27, 2023

Choose a reason for hiding this comment

Uh oh!

flowguru Mar 27, 2023

Choose a reason for hiding this comment

Uh oh!

foundationdb-ci commented Mar 27, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

Uh oh!

foundationdb-ci commented Mar 27, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Uh oh!

foundationdb-ci commented Mar 27, 2023

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Uh oh!

fdb-windows-ci commented Mar 27, 2023

Doxense CI Report for Windows 10

Uh oh!

foundationdb-ci commented Mar 27, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

Uh oh!

foundationdb-ci commented Mar 27, 2023

Result of foundationdb-pr on Linux CentOS 7

Uh oh!

foundationdb-ci commented Mar 27, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Uh oh!

foundationdb-ci commented Mar 27, 2023

Result of foundationdb-pr-macos on macOS Ventura 13.x

flowguru commented Mar 23, 2023 •

edited

Loading