Skip to content

Update info trigger new DB info update immediately [release-7.1] #9778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jzhou77 merged 1 commit into from
Mar 23, 2023
Merged

Update info trigger new DB info update immediately [release-7.1] #9778

jzhou77 merged 1 commit into from
Mar 23, 2023

Conversation

@jzhou77
Copy link
Contributor

@jzhou77 jzhou77 commented Mar 22, 2023

Cherry picks #9772

This is an issue found in simulation that when the cluster controller cannot communicate with a registered worker, the CC will be blocked in broadcastDBInfoRequest indefinitely. When a new worker joins the cluster, although updateDBInfo.trigger() is called, it won't trigger a new serverDbInfo updater.

This PR fixes this issue by starting a new round of DbInfo updater in the middle of broadcastDBInfoRequest.

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@jzhou77 jzhou77 requested review from flowguru, halfprice and xis19 March 22, 2023 21:02
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 22, 2023

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

  • Commit ID: 5815d89
  • Duration 0:16:04
  • Result: ❌ FAILED
  • Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /opt/homebrew/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 22, 2023

Result of foundationdb-pr-macos on macOS Ventura 13.x

  • Commit ID: 5815d89
  • Duration 0:19:19
  • Result: ❌ FAILED
  • Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /usr/local/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 22, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 5815d89
  • Duration 0:38:45
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Mar 22, 2023

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 22, 2023

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 5815d89
  • Duration 1:06:36
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

xis19
xis19 approved these changes Mar 22, 2023
View reviewed changes
fdbserver/ClusterController.actor.cpp
TraceEvent("DBInfoStartBroadcast", self->id).log();
TraceEvent("DBInfoStartBroadcast", self->id)
.detail("MasterLifetime", self->db.serverInfo->get().masterLifetime.toString());
;
Copy link
Collaborator

@xis19 xis19 Mar 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this ; is unnecessary?

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 22, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 5815d89
  • Duration 2:03:54
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@jzhou77 jzhou77 merged commit e86a9ab into apple:release-7.1 Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xis19 xis19 xis19 approved these changes

+2 more reviewers

@halfprice halfprice halfprice approved these changes

@flowguru flowguru flowguru approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jzhou77 @foundationdb-ci @fdb-windows-ci @xis19 @halfprice @flowguru