The sharded rocks implementation skipped on TSS handling. Backfill. #9759

saintstack · 2023-03-21T00:04:05Z

fdbserver/MoveKeys.actor.cpp Make startMoveShards work like startMoveKeys handling TSS. Make finishMoveShards work like finishMoveKeys handling TSS.

saintstack · 2023-03-21T00:04:43Z

On Testing:

Running simulation with SHARD_ENCODE_LOCATION_METADATA=true, and the below change, turned up a class of failures such as ./build_output/bin/fdbserver -r simulation -f ./build_output/correctness/tests/slow/ddbalance.toml -b off -s 3264324653 -- in storageserver.actor.cpp line 8380, the assert would fail. With this PR in place, this test no longer fails.
Ran loadings over a few hours with TSS enabled along w/ sharded rocks storage engine and tracked metrics across a TSSJointID pairing w/ the TSS surviving to the end (no chaos though).

diff --git a/fdbserver/SimulatedCluster.actor.cpp b/fdbserver/SimulatedCluster.actor.cpp
index caf0bd9b5..d152a2ca9 100644
--- a/fdbserver/SimulatedCluster.actor.cpp
+++ b/fdbserver/SimulatedCluster.actor.cpp
@@ -2047,9 +2047,7 @@ void SimulationConfig::setProcessesPerMachine(const TestConfig& testConfig) {
 // Also configures the cluster behaviour through setting some flags on the simulator.
 void SimulationConfig::setTss(const TestConfig& testConfig) {
        int tssCount = 0;
-       // TODO: Support TSS in SHARD_ENCODE_LOCATION_METADATA mode.
-       if (!testConfig.simpleConfig && !testConfig.disableTss && !SERVER_KNOBS->SHARD_ENCODE_LOCATION_METADATA &&
-           deterministicRandom()->random01() < 0.25) {
+       if (!testConfig.simpleConfig && !testConfig.disableTss && deterministicRandom()->random01() < 1.0) {
                // 1 or 2 tss
                tssCount = deterministicRandom()->randomInt(1, 3);
        }

foundationdb-ci · 2023-03-21T00:08:46Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: bd6bcdd
Duration 0:04:31
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-03-21T00:08:49Z

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: bd6bcdd
Duration 0:04:32
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-03-21T00:08:50Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: bd6bcdd
Duration 0:04:32
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2023-03-21T00:08:51Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: bd6bcdd
Duration 0:04:33
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-03-21T00:09:39Z

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: bd6bcdd
Duration 0:05:22
Result: ❌ FAILED
Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

fdb-windows-ci · 2023-03-21T01:47:25Z

Doxense CI Report for Windows 10

Commit ID: bd6bcdd
Result: ✔️ SUCCEEDED
Build Logs (available for 30 days)

fdb-windows-ci · 2023-03-21T03:50:58Z

Doxense CI Report for Windows 10

Commit ID: bd2ce76
Result: ✔️ SUCCEEDED
Build Logs (available for 30 days)

foundationdb-ci · 2023-03-21T03:51:58Z

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: bd2ce76
Duration 0:23:32
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-03-21T04:22:20Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: bd2ce76
Duration 0:53:57
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-03-21T04:25:22Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: bd2ce76
Duration 0:57:01
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-03-21T04:49:39Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: bd2ce76
Duration 1:21:14
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

saintstack · 2023-03-23T18:07:59Z

More testing. Added below diff when running 2.5M simulation (suggested by @liquid-helium ):

diff --git a/fdbserver/SimulatedCluster.actor.cpp b/fdbserver/SimulatedCluster.actor.cpp
index 784b29e54..96dcb5bda 100644
--- a/fdbserver/SimulatedCluster.actor.cpp
+++ b/fdbserver/SimulatedCluster.actor.cpp
@@ -1644,7 +1644,7 @@ void SimulationConfig::setEncryptionAtRestMode(const TestConfig& testConfig) {
 void SimulationConfig::setStorageEngine(const TestConfig& testConfig) {
        // Using [0, 4) to disable the RocksDB storage engine.
        // TODO: Figure out what is broken with the RocksDB engine in simulation.
-       int storage_engine_type = deterministicRandom()->randomInt(0, 6);
+       int storage_engine_type = 5/*Sharded*/; // deterministicRandom()->randomInt(0, 6);
        if (db.encryptionAtRestMode.isEncryptionEnabled()) {
                // Only storage engine supporting encryption is Redwood.
                storage_engine_type = 3;

Most tests run w/ sharded rocks with above change. Lots of failures -- 789 -- but an overview doesn't find any fails because of TSS'ing.

liquid-helium

Thanks for implementing this!

liquid-helium · 2023-03-30T17:36:51Z

fdbserver/MoveKeys.actor.cpp


-			state Transaction tr(occ);
+			// RYW to optimize re-reading the same key ranges. See readTSSMappingRYW
+			state Reference<ReadYourWritesTransaction> tr = makeReference<ReadYourWritesTransaction>(occ);


Do we have to use ReadYourWritesTransaction here? Transaction was used intentionally since ReadYourWritesTransaction is not compatible with unassignServerKeys(), which is called within startMoveShards(), currently it is not actually called since the condition is always false, but it could be triggered in the future.

Sorry I should have added a comment here.

I was modeling what startMoveKeys does. The call to readTSSMappingRYW wants a RYWTransaction. Let me go back to plain Transaction (and it looks like readTSSMappingRYW internally doesn't actually need RYWT....).

liquid-helium · 2023-03-30T17:40:48Z

fdbserver/MoveKeys.actor.cpp

+				wait(checkMoveKeysLock(&(tr->getTransaction()), lock, ddEnabledState));

-				Optional<Value> val = wait(tr.get(dataMoveKeyFor(dataMoveId)));
+				if (!loadedTssMapping) {


nit: move this readTSSMappingRYW() block to line 1335, after we evaluate the DataMoveMetaData since we could exit early and end up not using the loaded TssMapping.

liquid-helium · 2023-03-30T17:49:48Z

fdbserver/MoveKeys.actor.cpp

 						readyServers.push_back(storageServerInterfaces[s].uniqueID);
 					}
 				}
+				int tssCount = 0;


Are we checking if tssCount is the same as the intended tssCount?

Again modeling what is done for the move of keys, it does a tssCount just to print. We are just doing same here.

saintstack · 2023-03-31T04:17:28Z

Address @liquid-helium feedback.

saintstack · 2023-03-31T17:57:04Z

Rebased and addressed @liquid-helium comments.

Reran simulation first with default 100k test count. Two failures. Unrelated.

Next ran 1M simulations w/ below patch in place to favor sharded rocks and tss:

diff --git a/fdbclient/ServerKnobs.cpp b/fdbclient/ServerKnobs.cpp
index 6d145c24b..5c889c44d 100644
--- a/fdbclient/ServerKnobs.cpp
+++ b/fdbclient/ServerKnobs.cpp
@@ -168,7 +168,7 @@ void ServerKnobs::initialize(Randomize randomize, ClientKnobs* clientKnobs, IsSi
        init( PRIORITY_ENFORCE_MOVE_OUT_OF_PHYSICAL_SHARD,           960 ); if( randomize && BUGGIFY ) PRIORITY_ENFORCE_MOVE_OUT_OF_PHYSICAL_SHARD = 360; // Set as the lowest priority

        // Data distribution
-       init( SHARD_ENCODE_LOCATION_METADATA,                       false ); if( randomize && BUGGIFY )  SHARD_ENCODE_LOCATION_METADATA = true;
+       init( SHARD_ENCODE_LOCATION_METADATA,                       true ); if( randomize && BUGGIFY )  SHARD_ENCODE_LOCATION_METADATA = true;
        init( ENABLE_DD_PHYSICAL_SHARD,                             false ); // EXPERIMENTAL; If true, SHARD_ENCODE_LOCATION_METADATA must be true; When true, optimization of data move between DCs is disabled
        init( MAX_PHYSICAL_SHARD_BYTES,                         10000000 ); // 10 MB; for ENABLE_DD_PHYSICAL_SHARD; smaller leads to larger number of physicalShard per storage server
        init( PHYSICAL_SHARD_METRICS_DELAY,                        300.0 ); // 300 seconds; for ENABLE_DD_PHYSICAL_SHARD
diff --git a/fdbserver/SimulatedCluster.actor.cpp b/fdbserver/SimulatedCluster.actor.cpp
index caf0bd9b5..d152a2ca9 100644
--- a/fdbserver/SimulatedCluster.actor.cpp
+++ b/fdbserver/SimulatedCluster.actor.cpp
@@ -2047,9 +2047,7 @@ void SimulationConfig::setProcessesPerMachine(const TestConfig& testConfig) {
 // Also configures the cluster behaviour through setting some flags on the simulator.
 void SimulationConfig::setTss(const TestConfig& testConfig) {
        int tssCount = 0;
-       // TODO: Support TSS in SHARD_ENCODE_LOCATION_METADATA mode.
-       if (!testConfig.simpleConfig && !testConfig.disableTss && !SERVER_KNOBS->SHARD_ENCODE_LOCATION_METADATA &&
-           deterministicRandom()->random01() < 0.25) {
+       if (!testConfig.simpleConfig && !testConfig.disableTss && deterministicRandom()->random01() < 1.0) {
                // 1 or 2 tss
                tssCount = deterministicRandom()->randomInt(1, 3);
        }
diff --git a/flow/Knobs.cpp b/flow/Knobs.cpp
index b95ffc9b3..4efc54ba2 100644
--- a/flow/Knobs.cpp
+++ b/flow/Knobs.cpp
@@ -238,7 +238,7 @@ void FlowKnobs::initialize(Randomize randomize, IsSimulated isSimulated) {
        init( ZERO_LENGTH_FILE_PAD,                                  1 );
        init( TRACE_FLUSH_INTERVAL,                               0.25 );
        init( TRACE_RETRY_OPEN_INTERVAL,                                                  1.00 );
-       init( MIN_TRACE_SEVERITY,                isSimulated ?  1 : 10, Atomic::NO ); // Related to the trace severity in Trace.h
+       init( MIN_TRACE_SEVERITY,                isSimulated ?  0 : 10, Atomic::NO ); // Related to the trace severity in Trace.h
        init( MAX_TRACE_SUPPRESSIONS,                              1e4 );
        init( TRACE_DATETIME_ENABLED,                             true ); // trace time in human readable format (always real time)
        init( TRACE_SYNC_ENABLED,                                    0 );

30 odd failures... Here is the list sorted and uniq'd:

TestFile="tests/fast/AtomicBackupToDBCorrectness.toml"
TestFile="tests/fast/BackupToDBCorrectnessClean.toml"
TestFile="tests/fast/BackupToDBCorrectness.toml"
TestFile="tests/fast/PhysicalShardMove.toml"
TestFile="tests/fast/SpecialKeySpaceRobustness.toml"
TestFile="tests/rare/Throttling.toml"
TestFile="tests/rare/TransactionTagApiCorrectness.toml"
TestFile="tests/restarting/from_7.1.0_until_7.2.0/VersionVectorEnableRestart-1.toml"
TestFile="tests/restarting/from_7.1.0_until_7.2.0/VersionVectorEnableRestart-2.toml"
TestFile="tests/restarting/from_7.3.0/DrUpgradeRestart-1.toml"
TestFile="tests/restarting/from_7.3.0/DrUpgradeRestart-2.toml"
TestFile="tests/restarting/from_7.3.0/UpgradeAndBackupRestore-1.toml"
TestFile="tests/restarting/from_7.3.0/UpgradeAndBackupRestore-2.toml"
TestFile="tests/slow/ApiCorrectnessAtomicRestore.toml"
TestFile="tests/slow/FastTriggeredWatches.toml"
TestFile="tests/slow/ParallelRestoreNewBackupCorrectnessAtomicOp.toml"

The TestFile="tests/fast/PhysicalShardMove.toml" looked like it could be related but the complaints were Reason="Consistency check: Shard size is more than 7.000000 std dev from estimate" ... an issue being worked on in another issue.

Identifier for my simulation runs was 20230331-041546-stack-9d22ddb0aa037311

foundationdb-ci · 2023-03-31T18:06:33Z

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: f14535c
Duration 0:14:33
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-03-31T18:07:47Z

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: f14535c
Duration 0:14:33
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

fdb-windows-ci · 2023-03-31T18:43:22Z

Doxense CI Report for Windows 10

Commit ID: f14535c
Result: ❌ FAILED
Build Logs (available for 30 days)

foundationdb-ci · 2023-03-31T18:51:40Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: f14535c
Duration 0:59:42
Result: ❌ FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-03-31T18:56:44Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: f14535c
Duration 1:04:48
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-03-31T19:59:40Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: f14535c
Duration 2:07:45
Result: ❌ FAILED
Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

saintstack · 2023-03-31T23:26:19Z

Non-change to retriever CI build (failures seem to be related to missing docker deploy found by He Liu)

foundationdb-ci · 2023-03-31T23:41:31Z

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: 57276d7
Duration 0:15:48
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-03-31T23:46:02Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: 57276d7
Duration 0:20:16
Result: ❌ FAILED
Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

fdb-windows-ci · 2023-04-01T00:02:06Z

Doxense CI Report for Windows 10

Commit ID: 57276d7
Result: ❌ FAILED
Build Logs (available for 30 days)

foundationdb-ci · 2023-04-01T00:11:39Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 57276d7
Duration 0:45:53
Result: ❌ FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

liquid-helium · 2023-04-03T18:20:54Z

fdbserver/MoveKeys.actor.cpp


 						// Update dest servers for this range to be equal to servers
-						krmSetPreviouslyEmptyRange(&tr,
+						krmSetPreviouslyEmptyRange(&(tr.getTransaction()),


nit: will &tr be sufficient?

Yes. Was copied from startMoveKeys. Let me fix.

foundationdb-ci · 2023-04-03T20:12:53Z

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: 2f25c08
Duration 0:16:51
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-04-03T20:29:18Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 2f25c08
Duration 0:33:21
Result: ❌ FAILED
Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-04-03T20:53:56Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: 2f25c08
Duration 0:57:56
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-04-03T22:03:56Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 2f25c08
Duration 2:07:57
Result: ❌ FAILED
Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

fdb-windows-ci · 2023-04-03T22:34:08Z

Doxense CI Report for Windows 10

Commit ID: 2f25c08
Result: ❌ FAILED
Build Logs (available for 30 days)

saintstack · 2023-04-04T04:59:46Z

The "Result of foundationdb-pr-cluster-tests on Linux CentOS 7" failure is the test_ycsb k8s integration test failing to deploy the cluster in the BeforeSuite. I see it on another concurrent PR so likely unrelated: #9759

Result of 'Result of foundationdb-pr on Linux CentOS 7' failure is below unit tests failing:

	 53 - fdb_c_client_config_tests (Failed)
	 54 - fdb_c_upgrade_from_prev3_gradual (Failed)
	 55 - fdb_c_upgrade_from_prev3_direct (Failed)
	 56 - fdb_c_upgrade_from_prev2_gradual (Failed)
	 57 - fdb_c_upgrade_from_prev2_direct (Failed)
	 58 - fdb_c_upgrade_from_prev (Failed)
	 60 - fdb_c_wiggle_and_upgrade (Failed)
	 61 - fdb_c_shim_library_tests (Failed)

Unit tests passed for another concurrent PR so perhaps related?

Retrying.

foundationdb-ci · 2023-04-04T05:23:45Z

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: 25355bf
Duration 0:17:58
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

fdb-windows-ci · 2023-04-04T05:48:35Z

Doxense CI Report for Windows 10

Commit ID: 25355bf
Result: ❌ FAILED
Build Logs (available for 30 days)

foundationdb-ci · 2023-04-04T05:58:35Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 25355bf
Duration 0:52:45
Result: ❌ FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-04-04T06:00:25Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: 25355bf
Duration 0:54:39
Result: ❌ FAILED
Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-04-04T07:10:43Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 25355bf
Duration 2:04:57
Result: ❌ FAILED
Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

foundationdb-ci · 2023-04-04T08:21:26Z

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Commit ID: 25355bf
Duration 0:15:10
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-04-04T08:36:31Z

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Commit ID: 25355bf
Duration 0:30:17
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-04-04T08:44:16Z

Result of foundationdb-pr-macos on macOS Ventura 13.x

Commit ID: 25355bf
Duration 0:38:03
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-04-04T08:49:31Z

Result of foundationdb-pr-clang on Linux CentOS 7

Commit ID: 25355bf
Duration 0:43:17
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-04-04T08:59:21Z

Result of foundationdb-pr on Linux CentOS 7

Commit ID: 25355bf
Duration 0:53:10
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)

foundationdb-ci · 2023-04-04T09:28:18Z

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Commit ID: 25355bf
Duration 1:22:03
Result: ✅ SUCCEEDED
Error: N/A
Build Log terminal output (available for 30 days)
Build Workspace zip file of the working directory (available for 30 days)
Cluster Test Logs zip file of the test logs (available for 30 days)

…pple#9759)

…9759) (#10034)

saintstack requested a review from liquid-helium March 22, 2023 20:37

liquid-helium reviewed Mar 30, 2023

View reviewed changes

saintstack force-pushed the sharded_tss branch from bd2ce76 to f14535c Compare March 31, 2023 17:51

saintstack force-pushed the sharded_tss branch from f14535c to 57276d7 Compare March 31, 2023 23:25

liquid-helium previously approved these changes Apr 3, 2023

View reviewed changes

saintstack dismissed liquid-helium’s stale review via 2f25c08 April 3, 2023 19:55

Fix nit found by He Liu

25355bf

saintstack force-pushed the sharded_tss branch from 2f25c08 to 25355bf Compare April 4, 2023 05:05

johscheuer closed this Apr 4, 2023

johscheuer reopened this Apr 4, 2023

liquid-helium approved these changes Apr 4, 2023

View reviewed changes

liquid-helium merged commit 2cb76d0 into apple:main Apr 4, 2023

saintstack added a commit to saintstack/foundationdb that referenced this pull request Apr 22, 2023

The sharded rocks implementation skipped on TSS handling. Backfill. (a…

c0619c2

…pple#9759)

saintstack mentioned this pull request Apr 22, 2023

[release-7.2] The sharded rocks implementation skipped on TSS handling #10034

Merged

saintstack added a commit to saintstack/foundationdb that referenced this pull request Apr 22, 2023

The sharded rocks implementation skipped on TSS handling. Backfill. (a…

e8cbd88

…pple#9759)

saintstack added a commit to saintstack/foundationdb that referenced this pull request Apr 24, 2023

The sharded rocks implementation skipped on TSS handling. Backfill. (a…

c2160de

…pple#9759)

jzhou77 pushed a commit that referenced this pull request Apr 24, 2023

The sharded rocks implementation skipped on TSS handling. Backfill. (#…

3e1f89b

…9759) (#10034)

The sharded rocks implementation skipped on TSS handling. Backfill. #9759

The sharded rocks implementation skipped on TSS handling. Backfill. #9759

Uh oh!

Conversation

saintstack commented Mar 21, 2023

Uh oh!

saintstack commented Mar 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

foundationdb-ci commented Mar 21, 2023

Result of foundationdb-pr on Linux CentOS 7

Uh oh!

foundationdb-ci commented Mar 21, 2023

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Uh oh!

foundationdb-ci commented Mar 21, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Uh oh!

foundationdb-ci commented Mar 21, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

Uh oh!

foundationdb-ci commented Mar 21, 2023

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

Uh oh!

fdb-windows-ci commented Mar 21, 2023

Doxense CI Report for Windows 10

Uh oh!

fdb-windows-ci commented Mar 21, 2023

Doxense CI Report for Windows 10

Uh oh!

foundationdb-ci commented Mar 21, 2023

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Uh oh!

foundationdb-ci commented Mar 21, 2023

Result of foundationdb-pr on Linux CentOS 7

Uh oh!

foundationdb-ci commented Mar 21, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

Uh oh!

foundationdb-ci commented Mar 21, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

Uh oh!

saintstack commented Mar 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

liquid-helium left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

saintstack commented Mar 31, 2023

Uh oh!

saintstack commented Mar 31, 2023

Uh oh!

foundationdb-ci commented Mar 31, 2023

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Uh oh!

foundationdb-ci commented Mar 31, 2023

Result of foundationdb-pr-clang-ide on Linux CentOS 7

Uh oh!

fdb-windows-ci commented Mar 31, 2023

Doxense CI Report for Windows 10

Uh oh!

foundationdb-ci commented Mar 31, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

Uh oh!

foundationdb-ci commented Mar 31, 2023

Result of foundationdb-pr on Linux CentOS 7

Uh oh!

foundationdb-ci commented Mar 31, 2023

saintstack commented Mar 21, 2023 •

edited

Loading

saintstack commented Mar 23, 2023 •

edited

Loading

saintstack commented Apr 4, 2023 •

edited

Loading