Skip to content

The consistency check should retry if it couldn't find all the commit proxies when getting key server locations #9744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sfc-gh-abeamon merged 2 commits into from
Mar 17, 2023
Merged

The consistency check should retry if it couldn't find all the commit proxies when getting key server locations #9744

sfc-gh-abeamon merged 2 commits into from
Mar 17, 2023

Conversation

@sfc-gh-abeamon
Copy link
Collaborator

@sfc-gh-abeamon sfc-gh-abeamon commented Mar 17, 2023

Also as a result, we no longer need to verify that a recovery completed when killing/rebooting a machine during the consistency check

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 17, 2023

Result of foundationdb-pr-clang-ide on Linux CentOS 7

  • Commit ID: dc2bd78
  • Duration 0:13:58
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@sfc-gh-abeamon sfc-gh-abeamon marked this pull request as ready for review March 17, 2023 19:17
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 17, 2023

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

  • Commit ID: dc2bd78
  • Duration 0:30:00
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 17, 2023

Result of foundationdb-pr-macos on macOS Ventura 13.x

  • Commit ID: dc2bd78
  • Duration 0:37:22
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

sfc-gh-dadkins
sfc-gh-dadkins previously approved these changes Mar 17, 2023
View reviewed changes
fdbserver/workloads/ConsistencyCheck.actor.cpp
//
// This requires an end-to-end comitting transaction to ensure recovery has started in case
// any stateless processes, like the commit proxy, were killed.
wait(::success(doEmptyCommit(cx)));
Copy link
Collaborator

@sfc-gh-dadkins sfc-gh-dadkins Mar 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting rid of this hack. You can also remove the doEmptyCommit function above, too. I only added it for this one call.

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 17, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: dc2bd78
  • Duration 0:53:21
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Mar 17, 2023

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 17, 2023

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: dc2bd78
  • Duration 0:55:54
  • Result: ❌ FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@jzhou77 jzhou77 mentioned this pull request Mar 17, 2023
Merged
18 tasks
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 17, 2023

Result of foundationdb-pr-clang-ide on Linux CentOS 7

  • Commit ID: fe5d092
  • Duration 0:15:09
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 17, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: dc2bd78
  • Duration 1:20:16
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 17, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: fe5d092
  • Duration 0:52:38
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 17, 2023

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: fe5d092
  • Duration 0:52:59
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@sfc-gh-abeamon sfc-gh-abeamon merged commit a685a01 into apple:main Mar 17, 2023
@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Mar 17, 2023

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 17, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: fe5d092
  • Duration 1:19:32
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@sfc-gh-abeamon sfc-gh-abeamon mentioned this pull request Mar 17, 2023
Merged
5 tasks
@sfc-gh-abeamon sfc-gh-abeamon deleted the fix-consistency-check-retry-on-get-key-servers branch March 28, 2023 22:16
@jzhou77 jzhou77 mentioned this pull request Apr 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sfc-gh-etschannen sfc-gh-etschannen sfc-gh-etschannen approved these changes

@sfc-gh-dadkins sfc-gh-dadkins sfc-gh-dadkins left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sfc-gh-abeamon @foundationdb-ci @fdb-windows-ci @sfc-gh-etschannen @sfc-gh-dadkins