Skip to content

fixing copy constructor error and adding test for it (Cherry-Pick #9711 to snowflake/release-71.3) #9715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sfc-gh-akejriwal merged 1 commit into from
Mar 15, 2023
Merged

fixing copy constructor error and adding test for it (Cherry-Pick #9711 to snowflake/release-71.3) #9715

sfc-gh-akejriwal merged 1 commit into from
Mar 15, 2023

Conversation

@sfc-gh-jslocum
Copy link
Collaborator

@sfc-gh-jslocum sfc-gh-jslocum commented Mar 15, 2023

Cherry-Pick of #9711

Original Description:

Passes 1000 /RestKmsConnector unit tests

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 15, 2023

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

  • Commit ID: 62ea33c
  • Duration 0:28:51
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 15, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 62ea33c
  • Duration 0:34:26
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 15, 2023

Result of foundationdb-pr-macos on macOS Ventura 13.x

  • Commit ID: 62ea33c
  • Duration 0:37:32
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 15, 2023

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 62ea33c
  • Duration 0:57:31
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

sfc-gh-ahusain
sfc-gh-ahusain approved these changes Mar 15, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-ahusain sfc-gh-ahusain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@sfc-gh-akejriwal sfc-gh-akejriwal merged commit b33c14f into apple:snowflake/release-71.3 Mar 15, 2023
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 15, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 62ea33c
  • Duration 1:20:24
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sfc-gh-ahusain sfc-gh-ahusain sfc-gh-ahusain approved these changes

@sfc-gh-akejriwal sfc-gh-akejriwal sfc-gh-akejriwal approved these changes

Assignees

@sfc-gh-ahusain sfc-gh-ahusain

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sfc-gh-jslocum @foundationdb-ci @sfc-gh-ahusain @sfc-gh-akejriwal