Skip to content

When a storage server fails to register, we need to throw that error to terminate it #9712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sfc-gh-etschannen merged 1 commit into from
Mar 16, 2023
Merged

When a storage server fails to register, we need to throw that error to terminate it #9712

sfc-gh-etschannen merged 1 commit into from
Mar 16, 2023

Conversation

@sfc-gh-abeamon
Copy link
Collaborator

@sfc-gh-abeamon sfc-gh-abeamon commented Mar 15, 2023

This bug can manifest as a quiet database failure because the cluster will repeatedly try to recruit a new SS on this process and fail because of the existing SS role.

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@sfc-gh-abeamon
When a storage server fails to register (e.g. due to worker_removed),…
9e09d91 
… we need to throw that error to terminate the SS.
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 15, 2023

Result of foundationdb-pr-clang-ide on Linux CentOS 7

  • Commit ID: 9e09d91
  • Duration 0:16:01
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 15, 2023

Result of foundationdb-pr-macos on macOS Ventura 13.x

  • Commit ID: 9e09d91
  • Duration 0:37:39
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 15, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 9e09d91
  • Duration 0:39:32
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 15, 2023

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 9e09d91
  • Duration 0:59:50
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 15, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 9e09d91
  • Duration 1:24:24
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Mar 15, 2023

Doxense CI Report for Windows 10

@sfc-gh-etschannen sfc-gh-etschannen merged commit a620225 into apple:main Mar 16, 2023
@sfc-gh-abeamon sfc-gh-abeamon mentioned this pull request Mar 16, 2023
Merged
5 tasks
jzhou77 pushed a commit to jzhou77/foundationdb that referenced this pull request Mar 16, 2023
@sfc-gh-abeamon @jzhou77
When a storage server fails to register (e.g. due to worker_removed),…
7ab24a7 
… we need to throw that error to terminate the SS. (apple#9712)
@jzhou77 jzhou77 mentioned this pull request Mar 16, 2023
Merged
18 tasks
@sfc-gh-abeamon sfc-gh-abeamon deleted the fix-storage-server-failure-on-register branch March 28, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sfc-gh-etschannen sfc-gh-etschannen sfc-gh-etschannen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sfc-gh-abeamon @foundationdb-ci @fdb-windows-ci @sfc-gh-etschannen