Skip to content

Fix KeyRangeRef::isCovered() (#9675) #9697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sfc-gh-akejriwal merged 1 commit into from
Mar 15, 2023
Merged

Fix KeyRangeRef::isCovered() (#9675) #9697

sfc-gh-akejriwal merged 1 commit into from
Mar 15, 2023

Conversation

@sfc-gh-huliu
Copy link
Collaborator

@sfc-gh-huliu sfc-gh-huliu commented Mar 14, 2023 •
edited
Loading

This PR fixed a bug in KeyRangeRef:isCovered(), which is used by hybrid restore.

cherry pick #9675

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@kakaiu @sfc-gh-huliu
Fix KeyRangeRef::isCovered() (apple#9675)
d8ca0f6 
* fix KeyRangeRef::isCovered()

* reproduce bug

* more unit test added

* fmt
@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Mar 15, 2023

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 15, 2023

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: d8ca0f6
  • Duration 0:59:46
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 15, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: d8ca0f6
  • Duration 1:02:42
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 15, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: d8ca0f6
  • Duration 1:24:50
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

sfc-gh-akejriwal
sfc-gh-akejriwal reviewed Mar 15, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-akejriwal sfc-gh-akejriwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the main PR number in the description so that Github can link the two PRs.

@sfc-gh-huliu
Copy link
Collaborator Author

sfc-gh-huliu commented Mar 15, 2023

Please add the main PR number in the description so that Github can link the two PRs.

Done. thank you!

@sfc-gh-akejriwal sfc-gh-akejriwal self-requested a review March 15, 2023 19:15
@sfc-gh-akejriwal sfc-gh-akejriwal merged commit e0b1b3b into apple:snowflake/release-71.3 Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sfc-gh-etschannen sfc-gh-etschannen sfc-gh-etschannen approved these changes

@sfc-gh-akejriwal sfc-gh-akejriwal sfc-gh-akejriwal approved these changes

@sfc-gh-jslocum sfc-gh-jslocum Awaiting requested review from sfc-gh-jslocum

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sfc-gh-huliu @fdb-windows-ci @foundationdb-ci @sfc-gh-etschannen @sfc-gh-akejriwal @kakaiu