Skip to content

Deflake test FastTriggeredWatches (Cherry-Pick #9627 to snowflake/release-71.3) #9689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sfc-gh-yajin merged 1 commit into from
Mar 14, 2023
Merged

Deflake test FastTriggeredWatches (Cherry-Pick #9627 to snowflake/release-71.3) #9689

sfc-gh-yajin merged 1 commit into from
Mar 14, 2023

Conversation

@sfc-gh-yajin
Copy link
Collaborator

@sfc-gh-yajin sfc-gh-yajin commented Mar 14, 2023

Cherry-Pick of #9627

Original Description:

In FastTriggeredWatchesWorkload, if the randomized new value for the given setKey happens to be the same as the current value, the following will hold

  • first is true, and
  • getDuration is 0, and
  • assertion lastReadVersion - ver >= SERVER_KNOBS->MAX_VERSIONS_IN_FLIGHT || lastReadVersion - ver < SERVER_KNOBS->VERSIONS_PER_SECOND * (25 + getDuration) will fail

To fix this, change the assertion to

assert(first || lastReadVersion - ver >= SERVER_KNOBS->MAX_VERSIONS_IN_FLIGHT ||
	lastReadVersion - ver < SERVER_KNOBS->VERSIONS_PER_SECOND * (25 + getDuration));

Test plan:
On c27cdcd:

  • Apply to the fix on top of the commit reported by Joshua test. Rerun the command to make sure it passes.
  • devRunCorrectnessFiltered +FastTriggeredWatches* --max-runs 10000

Replace this text with your description here...

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Mar 14, 2023

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 14, 2023

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: cb4b3c6
  • Duration 1:04:58
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 14, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: cb4b3c6
  • Duration 1:05:25
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 14, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: cb4b3c6
  • Duration 1:26:39
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@sfc-gh-yajin
Copy link
Collaborator Author

sfc-gh-yajin commented Mar 14, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: cb4b3c6
  • Duration 1:26:39
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

Failure is

FoundationDBStatus when fetching the status of a FoundationDB cluster [It] shouldn't report fdbserver processes as clients
/codebuild/output/src530714171/src/github.com/apple/foundationdb/fdb-kubernetes-tests/tests/test_foundationdb_status/foundationdb_status_test.go:76

  [FAILED] Unexpected error:
      <*errors.errorString | 0xc00028e7a0>: {
          s: "not an object or array",
      }
      not an object or array
  occurred

Not related to this PR

@sfc-gh-yajin sfc-gh-yajin merged commit bc8b0ff into snowflake/release-71.3 Mar 14, 2023
@sfc-gh-yajin sfc-gh-yajin deleted the pr-9627-snowflake_release-71.3 branch March 14, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sfc-gh-abeamon sfc-gh-abeamon sfc-gh-abeamon approved these changes

@sfc-gh-akejriwal sfc-gh-akejriwal sfc-gh-akejriwal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sfc-gh-yajin @fdb-windows-ci @foundationdb-ci @sfc-gh-abeamon @sfc-gh-akejriwal