Skip to content

Fix specialkeyspace workload [release-7.1] #9681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jzhou77 merged 3 commits into from
Mar 15, 2023
Merged

Fix specialkeyspace workload [release-7.1] #9681

jzhou77 merged 3 commits into from
Mar 15, 2023

Conversation

@jzhou77
Copy link
Contributor

@jzhou77 jzhou77 commented Mar 13, 2023

This part of code is known to have issues with GlobalConfig's initialization. The main branch has refactored a lot, so this is not a cherrypick, but to fix the workload.

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@jzhou77
Remove profile code from SpecialKeySpace workload
c52b18f 
This part of code has problems with GlobalConfig and is buggy.
@jzhou77 jzhou77 requested review from sfc-gh-clin and xis19 March 13, 2023 22:11
sfc-gh-clin
sfc-gh-clin approved these changes Mar 13, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-clin sfc-gh-clin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 13, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: c52b18f
  • Duration 0:43:48
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 13, 2023

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: c52b18f
  • Duration 1:08:25
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Mar 14, 2023

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 14, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: c52b18f
  • Duration 2:12:30
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

xis19
xis19 reviewed Mar 14, 2023
View reviewed changes
Copy link
Collaborator

@xis19 xis19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that there are many more lines of code that main does not have in the release 7.1 branch. e.g. test ordered option keys, etc. Do we want to remove them too?

@jzhou77
Copy link
Contributor Author

jzhou77 commented Mar 14, 2023

It seems that there are many more lines of code that main does not have in the release 7.1 branch. e.g. test ordered option keys, etc. Do we want to remove them too?

My thinking is that as long as that code doesn't fail, we can keep them. I am not sure about that code.

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Mar 14, 2023

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 14, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: cb90dd3
  • Duration 0:49:28
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 14, 2023

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: cb90dd3
  • Duration 1:04:41
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Mar 14, 2023

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 14, 2023

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 2443616
  • Duration 0:38:13
  • Result: ❌ FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 14, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 2443616
  • Duration 0:39:53
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 14, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: cb90dd3
  • Duration 2:02:38
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 14, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 2443616
  • Duration 1:15:21
  • Result: ❌ FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

xis19
xis19 approved these changes Mar 14, 2023
View reviewed changes
Copy link
Collaborator

@xis19 xis19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not quite sure about this change though...

@jzhou77 jzhou77 merged commit 7d3044d into apple:release-7.1 Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xis19 xis19 xis19 approved these changes

@sfc-gh-clin sfc-gh-clin sfc-gh-clin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jzhou77 @foundationdb-ci @fdb-windows-ci @xis19 @sfc-gh-clin