Skip to content

The isHostname function could cause an unknown_error if regex parsing failed #9676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jzhou77 merged 1 commit into from
Mar 13, 2023
Merged

The isHostname function could cause an unknown_error if regex parsing failed #9676

jzhou77 merged 1 commit into from
Mar 13, 2023

Conversation

@sfc-gh-abeamon
Copy link
Collaborator

@sfc-gh-abeamon sfc-gh-abeamon commented Mar 13, 2023

This catches the std::exception, logs a trace event, and converts it to an FDB exception

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@sfc-gh-abeamon sfc-gh-abeamon requested a review from xis19 March 13, 2023 18:46
@sfc-gh-abeamon sfc-gh-abeamon mentioned this pull request Mar 13, 2023
Merged
5 tasks
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 13, 2023

Result of foundationdb-pr-clang-ide on Linux CentOS 7

  • Commit ID: 0e06052
  • Duration 0:24:11
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 13, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 0e06052
  • Duration 0:37:53
  • Result: ❌ FAILED
  • Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Mar 13, 2023

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 13, 2023

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 0e06052
  • Duration 1:17:04
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 13, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 0e06052
  • Duration 1:38:39
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@jzhou77 jzhou77 merged commit d54e24e into apple:main Mar 13, 2023
@jzhou77 jzhou77 mentioned this pull request Mar 16, 2023
Merged
18 tasks
@sfc-gh-abeamon sfc-gh-abeamon deleted the handle-hostname-parse-error branch March 28, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jzhou77 jzhou77 jzhou77 approved these changes

@xis19 xis19 Awaiting requested review from xis19

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sfc-gh-abeamon @foundationdb-ci @fdb-windows-ci @jzhou77