Skip to content

Fix KeyRangeRef::isCovered() #9675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kakaiu merged 6 commits into from
Mar 14, 2023
Merged

Fix KeyRangeRef::isCovered() #9675

kakaiu merged 6 commits into from
Mar 14, 2023

Conversation

@kakaiu
Copy link
Member

@kakaiu kakaiu commented Mar 13, 2023 •
edited
Loading

Fix KeyRangeRef::isCovered() used by PR #7965 and PR #9628

Pass 100K test with two unrelated failures:
20230314-163623-zhewang-050a8193839d7187 compressed=True data_size=32354993 duration=4195635 ended=100000 fail=2 fail_fast=10 max_runs=100000 pass=99998 priority=100 remaining=0 runtime=0:59:35 sanity=False started=100000 stopped=20230314-173558 submitted=20230314-163623 timeout=5400 username=zhewang

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@kakaiu kakaiu requested a review from sfc-gh-huliu March 13, 2023 18:38
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 13, 2023

Result of foundationdb-pr-clang-ide on Linux CentOS 7

  • Commit ID: 1b29799
  • Duration 0:26:24
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 13, 2023

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 1b29799
  • Duration 0:41:01
  • Result: ❌ FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 13, 2023

Result of foundationdb-pr-clang-ide on Linux CentOS 7

  • Commit ID: 45ddec1
  • Duration 0:15:33
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 13, 2023

Result of foundationdb-pr-clang-ide on Linux CentOS 7

  • Commit ID: a908972
  • Duration 0:04:18
  • Result: ❌ FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 13, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: a908972
  • Duration 0:04:22
  • Result: ❌ FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 13, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: a908972
  • Duration 0:04:23
  • Result: ❌ FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 13, 2023

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: a908972
  • Duration 0:04:22
  • Result: ❌ FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 13, 2023

Result of foundationdb-pr-macos on macOS Ventura 13.x

  • Commit ID: a908972
  • Duration 0:06:08
  • Result: ❌ FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 13, 2023

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

  • Commit ID: 45ddec1
  • Duration 0:28:31
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 13, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 1b29799
  • Duration 1:23:31
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 13, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 1b29799
  • Duration 1:30:53
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 13, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 45ddec1
  • Duration 0:50:30
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Mar 13, 2023

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 13, 2023

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 45ddec1
  • Duration 1:06:56
  • Result: ❌ FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 13, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 45ddec1
  • Duration 1:17:17
  • Result: ❌ FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

liquid-helium
liquid-helium previously approved these changes Mar 13, 2023
View reviewed changes
sfc-gh-huliu
sfc-gh-huliu previously approved these changes Mar 13, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-huliu sfc-gh-huliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for figuring out the problem and fixing the bug!!

@kakaiu kakaiu closed this Mar 14, 2023
@kakaiu kakaiu reopened this Mar 14, 2023
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 14, 2023

Result of foundationdb-pr-clang-ide on Linux CentOS 7

  • Commit ID: a908972
  • Duration 0:04:19
  • Result: ❌ FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 14, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: a908972
  • Duration 0:04:22
  • Result: ❌ FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 14, 2023

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: a908972
  • Duration 0:04:25
  • Result: ❌ FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 14, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: a908972
  • Duration 0:04:25
  • Result: ❌ FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 14, 2023

Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x

  • Commit ID: a908972
  • Duration 0:05:35
  • Result: ❌ FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 14, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: c2d65f0
  • Duration 0:04:32
  • Result: ❌ FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 14, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: c2d65f0
  • Duration 0:04:36
  • Result: ❌ FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 14, 2023

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: c2d65f0
  • Duration 0:04:39
  • Result: ❌ FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 14, 2023

Result of foundationdb-pr-clang-ide on Linux CentOS 7

  • Commit ID: c2d65f0
  • Duration 0:04:40
  • Result: ❌ FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@kakaiu kakaiu dismissed stale reviews from sfc-gh-huliu and liquid-helium via 096af56 March 14, 2023 17:47
@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Mar 14, 2023

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 14, 2023

Result of foundationdb-pr-clang-ide on Linux CentOS 7

  • Commit ID: 096af56
  • Duration 0:17:59
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 14, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 096af56
  • Duration 0:40:43
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 14, 2023

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 096af56
  • Duration 0:46:42
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Mar 14, 2023

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Mar 14, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 096af56
  • Duration 1:30:20
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@kakaiu kakaiu merged commit 7d2766b into apple:main Mar 14, 2023
sfc-gh-huliu pushed a commit to sfc-gh-huliu/foundationdb that referenced this pull request Mar 14, 2023
@kakaiu @sfc-gh-huliu
Fix KeyRangeRef::isCovered() (apple#9675)
d8ca0f6 
* fix KeyRangeRef::isCovered()

* reproduce bug

* more unit test added

* fmt
@sfc-gh-huliu sfc-gh-huliu mentioned this pull request Mar 15, 2023
Merged
5 tasks
sfc-gh-akejriwal pushed a commit that referenced this pull request Mar 15, 2023
@sfc-gh-huliu @kakaiu
Fix KeyRangeRef::isCovered() (#9675) (#9697)
e0b1b3b 
* fix KeyRangeRef::isCovered()

* reproduce bug

* more unit test added

* fmt

Co-authored-by: Zhe Wang <[email protected]>
jzhou77 pushed a commit to jzhou77/foundationdb that referenced this pull request Mar 16, 2023
@kakaiu @jzhou77
Fix KeyRangeRef::isCovered() (apple#9675)
b781467 
* fix KeyRangeRef::isCovered()

* reproduce bug

* more unit test added

* fmt
@jzhou77 jzhou77 mentioned this pull request Mar 16, 2023
Merged
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sfc-gh-huliu sfc-gh-huliu sfc-gh-huliu approved these changes

@liquid-helium liquid-helium Awaiting requested review from liquid-helium

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kakaiu @foundationdb-ci @fdb-windows-ci @liquid-helium @sfc-gh-huliu