Skip to content

Bumps minimum cmake required version. #9438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xis19 merged 1 commit into from
Mar 7, 2023
Merged

Bumps minimum cmake required version. #9438

xis19 merged 1 commit into from
Mar 7, 2023

Conversation

@jzhou77
Copy link
Contributor

@jzhou77 jzhou77 commented Feb 22, 2023 •
edited
Loading

@mavenraven found 3.1.8 can no longer compile FDB, so he bumps the version.

CI failure of correctness is not related.

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Feb 22, 2023

Result of foundationdb-pr-clang-ide on Linux CentOS 7

  • Commit ID: a672ac0
  • Duration 0:17:27
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Feb 22, 2023

Result of foundationdb-pr-macos-m1 on macOS Monterey 12.x

  • Commit ID: a672ac0
  • Duration 0:33:43
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Feb 22, 2023

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Feb 22, 2023

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: a672ac0
  • Duration 0:44:36
  • Result: ❌ FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Feb 22, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: a672ac0
  • Duration 1:10:51
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Feb 22, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: a672ac0
  • Duration 1:26:06
  • Result: ❌ FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@jzhou77 jzhou77 marked this pull request as ready for review February 22, 2023 16:39
@jzhou77 jzhou77 requested a review from ammolitor February 22, 2023 16:39
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Feb 23, 2023

Result of foundationdb-pr-clang-ide on Linux CentOS 7

  • Commit ID: c8c16e5
  • Duration 0:14:48
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Feb 23, 2023

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Feb 23, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: c8c16e5
  • Duration 0:45:30
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Feb 23, 2023

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: c8c16e5
  • Duration 0:47:04
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Feb 23, 2023

Result of foundationdb-pr-macos on macOS Monterey 12.x

  • Commit ID: c8c16e5
  • Duration 0:47:24
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Feb 23, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: c8c16e5
  • Duration 3:00:39
  • Result: ❌ FAILED
  • Error: Build has timed out.
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@jzhou77 jzhou77 requested a review from xis19 March 6, 2023 23:59
@xis19 xis19 merged commit 6c1a0ad into apple:main Mar 7, 2023
sfc-gh-satherton added a commit to sfc-gh-satherton/foundationdb that referenced this pull request Mar 8, 2023
@sfc-gh-satherton
Bumps minimum cmake required version. (Cherry-Pick apple#9438 to snow…
a15fdef 
…flake/release-71.3)
sfc-gh-satherton added a commit to sfc-gh-satherton/foundationdb that referenced this pull request Mar 8, 2023
@sfc-gh-satherton
Bumps minimum cmake required version. (Cherry-Pick apple#9438 to snow…
bd3627f 
…flake/release-71.3)
sfc-gh-satherton added a commit to sfc-gh-satherton/foundationdb that referenced this pull request Mar 8, 2023
@sfc-gh-satherton
Bumps minimum cmake required version. (Cherry-Pick apple#9438 to snow…
067aba4 
…flake/release-71.3)
@jzhou77 jzhou77 mentioned this pull request Mar 16, 2023
Merged
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xis19 xis19 xis19 approved these changes

@ammolitor ammolitor Awaiting requested review from ammolitor

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jzhou77 @foundationdb-ci @fdb-windows-ci @xis19 @mavenraven