Skip to content

Release 7.2: Cherry pick pull request #9225 #9262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jzhou77 merged 2 commits into from
Jan 30, 2023
Merged

Release 7.2: Cherry pick pull request #9225 #9262

jzhou77 merged 2 commits into from
Jan 30, 2023

Conversation

@sbodagala
Copy link
Contributor

@sbodagala sbodagala commented Jan 27, 2023 •
edited
Loading

Merge pull request #9225 from sbodagala/main.

  • Do not add fdbserver processes to the client list.

Note: Server processes started getting reported as clients since 7.1.0 (not sure if this change in behavior was intentional or not), and this breaks the operator upgrade logic.

Testing:

Simulation tests: 20230127-200827-sre-9caa6a4d5198a657 (in progress).

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@sbodagala
- Do not add fdbserver processes to the client list. (apple#9225)
92b0e93 
Note: Server processes started getting reported as clients since 7.1.0
(not sure if this change in behavior was intentional or not), and this
breaks the operator upgrade logic.
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jan 27, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: f52f8d7
  • Duration 0:23:28
  • Result: ❌ FAILED
  • Error: Error while executing command: docker build --label "org.foundationdb.version=${FDB_VERSION}" --label "org.foundationdb.build_date=${BUILD_DATE}" --label "org.foundationdb.commit=${COMMIT_SHA}" --progress plain --build-arg FDB_VERSION="${FDB_VERSION}" --build-arg FDB_LIBRARY_VERSIONS="${FDB_VERSION}" --build-arg FDB_WEBSITE="${FDB_WEBSITE}" --tag foundationdb/base:${FDB_VERSION}-${COMMIT_SHA} --file Dockerfile --target base .. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jan 27, 2023

Result of foundationdb-pr-macos-m1 on macOS Monterey 12.x

  • Commit ID: 92b0e93
  • Duration 0:35:37
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jan 27, 2023

Result of foundationdb-pr-macos on macOS Monterey 12.x

  • Commit ID: 92b0e93
  • Duration 0:45:09
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jan 27, 2023

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 92b0e93
  • Duration 0:51:30
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jan 27, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: f52f8d7
  • Duration 0:48:59
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jan 27, 2023

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 92b0e93
  • Duration 0:52:31
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jan 27, 2023

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: f52f8d7
  • Duration 0:51:50
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Jan 27, 2023

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Jan 27, 2023

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 92b0e93
  • Duration 1:18:33
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

johscheuer
johscheuer approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@johscheuer johscheuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jzhou77 jzhou77 merged commit 6121750 into apple:release-7.2 Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johscheuer johscheuer johscheuer approved these changes

@jzhou77 jzhou77 jzhou77 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sbodagala @foundationdb-ci @fdb-windows-ci @johscheuer @jzhou77