Skip to content

Fix backup worker assertion failure [release-7.1] #8887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jzhou77 merged 1 commit into from
Nov 22, 2022
Merged

Fix backup worker assertion failure [release-7.1] #8887

jzhou77 merged 1 commit into from
Nov 22, 2022

Conversation

@jzhou77
Copy link
Contributor

@jzhou77 jzhou77 commented Nov 19, 2022 •
edited
Loading

cherrypick #8886

The number of released bytes exceeds the number of acquired bytes in locks. This is because the bytes counted towards release is calculated after a "wait", when more bytes could be allocated.

20221119-173034-jzhou-f6b6a287506b8645

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@jzhou77
Fix backup worker assertion failure
5a12979 
The number of released bytes exceeds the number of acquired bytes in locks.
This is because the bytes counted towards release is calculated after a "wait",
when more bytes could be allocated.
@jzhou77 jzhou77 changed the title Fix backup worker assertion failure Fix backup worker assertion failure [release-7.1] Nov 19, 2022
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 19, 2022

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 5a12979
  • Duration 0:37:20
  • Result: ❌ FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 19, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 19, 2022

Result of foundationdb-pr on Linux CentOS 7

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Nov 19, 2022

Doxense CI Report for Windows 10

@jzhou77 jzhou77 merged commit ae6ae7c into apple:release-7.1 Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@halfprice halfprice halfprice approved these changes

@liquid-helium liquid-helium liquid-helium approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jzhou77 @foundationdb-ci @fdb-windows-ci @halfprice @liquid-helium