Skip to content

Rocksdb suggest compact range checks #8848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jzhou77 merged 1 commit into from
Nov 18, 2022
Merged

Rocksdb suggest compact range checks #8848

jzhou77 merged 1 commit into from
Nov 18, 2022

Conversation

@neethuhaneesha
Copy link
Contributor

@neethuhaneesha neethuhaneesha commented Nov 16, 2022

Rocksdb suggest compact range checks

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 16, 2022

Result of foundationdb-pr-clang-ide on Linux CentOS 7

liquid-helium
liquid-helium previously approved these changes Nov 16, 2022
View reviewed changes
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 17, 2022

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: c8383b7
  • Duration 1:01:01
  • Result: ❌ FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

xy-54321
xy-54321 previously approved these changes Nov 17, 2022
View reviewed changes
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 17, 2022

Result of foundationdb-pr on Linux CentOS 7

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 17, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: c8383b7
  • Duration 1:58:28
  • Result: ❌ FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Nov 17, 2022

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 17, 2022

Result of foundationdb-pr-clang-ide on Linux CentOS 7

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Nov 17, 2022

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 17, 2022

Result of foundationdb-pr-macos-m1 on macOS BigSur 11.5.2

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 17, 2022

Result of foundationdb-pr-macos on macOS Monterey 12.x

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 17, 2022

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 4c2e23d
  • Duration 0:53:03
  • Result: ❌ FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 17, 2022

Result of foundationdb-pr-clang on Linux CentOS 7

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 17, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 4c2e23d
  • Duration 1:57:19
  • Result: ❌ FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 17, 2022

Result of foundationdb-pr-clang-ide on Linux CentOS 7

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 17, 2022

Result of foundationdb-pr-macos-m1 on macOS BigSur 11.5.2

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 17, 2022

Result of foundationdb-pr-macos on macOS Monterey 12.x

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 17, 2022

Result of foundationdb-pr-clang on Linux CentOS 7

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 17, 2022

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 2e67bf9
  • Duration 1:12:15
  • Result: ❌ FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Nov 17, 2022

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 17, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 2e67bf9
  • Duration 2:01:49
  • Result: ❌ FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@neethuhaneesha neethuhaneesha mentioned this pull request Nov 17, 2022
Merged
5 tasks
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 17, 2022

Result of foundationdb-pr-clang-ide on Linux CentOS 7

@neethuhaneesha neethuhaneesha mentioned this pull request Nov 17, 2022
Merged
5 tasks
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 18, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: b46c9eb
  • Duration 2:01:48
  • Result: ❌ FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 18, 2022

Result of foundationdb-pr on Linux CentOS 7

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 18, 2022

Result of foundationdb-pr-clang on Linux CentOS 7

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Nov 18, 2022

Doxense CI Report for Windows 10

@jzhou77 jzhou77 merged commit 2a74624 into apple:main Nov 18, 2022
@neethuhaneesha neethuhaneesha deleted the suggest-compacts branch April 3, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jzhou77 jzhou77 Awaiting requested review from jzhou77

2 more reviewers

@liquid-helium liquid-helium liquid-helium approved these changes

@xy-54321 xy-54321 xy-54321 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@neethuhaneesha @foundationdb-ci @fdb-windows-ci @liquid-helium @xy-54321 @jzhou77