Skip to content

Fix ASan failure heap use after free in status json generation #8684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jzhou77 merged 3 commits into from
Nov 4, 2022
Merged

Fix ASan failure heap use after free in status json generation #8684

jzhou77 merged 3 commits into from
Nov 4, 2022

Conversation

@jzhou77
Copy link
Contributor

@jzhou77 jzhou77 commented Nov 3, 2022 •
edited
Loading

incomplete_reasons can be destroyed already.

20221103-192945-jzhou-c791074d389af86b failed with tests/rare/ThroughputQuota.toml, which is unrelated to this change.

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@jzhou77
Fix ASan failure heap use after free
b02509e 
"incomplete_reasons" may already be destroyed.
@jzhou77 jzhou77 mentioned this pull request Nov 3, 2022
Merged
5 tasks
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 3, 2022

Result of foundationdb-pr-clang-ide on Linux CentOS 7

@jzhou77 jzhou77 marked this pull request as ready for review November 3, 2022 19:47
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 3, 2022

Result of foundationdb-pr-clang-ide on Linux CentOS 7

halfprice
halfprice reviewed Nov 3, 2022
View reviewed changes
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 3, 2022

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: ee43f25
  • Duration 1:01:30
  • Result: ❌ FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 3, 2022

Result of foundationdb-pr-macos-m1 on macOS BigSur 11.5.2

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 3, 2022

Result of foundationdb-pr-clang on Linux CentOS 7

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 3, 2022

Result of foundationdb-pr on Linux CentOS 7

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Nov 3, 2022

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 3, 2022

Result of foundationdb-pr on Linux CentOS 7

@jzhou77 jzhou77 requested a review from halfprice November 3, 2022 21:04
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 3, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: ee43f25
  • Duration 2:00:56
  • Result: ❌ FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 3, 2022

Result of foundationdb-pr-clang-ide on Linux CentOS 7

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 3, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 2a5ff5b
  • Duration 1:57:45
  • Result: ❌ FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 3, 2022

Result of foundationdb-pr-clang on Linux CentOS 7

@jzhou77 jzhou77 mentioned this pull request Nov 3, 2022
Merged
5 tasks
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 3, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 928be56
  • Duration 2:07:47
  • Result: ❌ FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 3, 2022

Result of foundationdb-pr on Linux CentOS 7

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Nov 4, 2022

Doxense CI Report for Windows 10

@jzhou77 jzhou77 merged commit ec471aa into apple:main Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sfc-gh-anoyes sfc-gh-anoyes Awaiting requested review from sfc-gh-anoyes

1 more reviewer

@halfprice halfprice halfprice approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jzhou77 @foundationdb-ci @fdb-windows-ci @halfprice