Skip to content

Fix ASan found memory bugs [release 7.1] #8683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jzhou77 merged 4 commits into from
Nov 4, 2022
Merged

Fix ASan found memory bugs [release 7.1] #8683

jzhou77 merged 4 commits into from
Nov 4, 2022

Conversation

@jzhou77
Copy link
Contributor

@jzhou77 jzhou77 commented Nov 3, 2022 •
edited
Loading

Cherrypick #8684

20221103-194349-jzhou-17fc65d1d5b90e81

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

sfc-gh-anoyes and others added 3 commits November 3, 2022 11:54
@sfc-gh-anoyes @jzhou77
outputBuffer may not be null-terminated, so don't convert to std::string
6af4626 
This fixes a heap buffer overflow caught by ASAN, and importantly not
valgrind, since valgrind currently doesn't run on the first binary in a
restarting test. The next commit will change that so we always run
valgrind on the binary under test.
@jzhou77
Fix ASan failure heap use after free
6d0291d 
"incomplete_reasons" may already be destroyed.
@jzhou77
Update 7.1 release notes
6757d52
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 3, 2022

Result of foundationdb-pr-macos on macOS Monterey 12.x

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 3, 2022

Result of foundationdb-pr-clang on Linux CentOS 7

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 3, 2022

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 6d0291d
  • Duration 0:58:42
  • Result: ❌ FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 3, 2022

Result of foundationdb-pr-clang on Linux CentOS 7

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 3, 2022

Result of foundationdb-pr on Linux CentOS 7

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 3, 2022

Result of foundationdb-pr on Linux CentOS 7

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 3, 2022

Result of foundationdb-pr on Linux CentOS 7

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Nov 3, 2022

Doxense CI Report for Windows 10

@jzhou77 jzhou77 marked this pull request as ready for review November 3, 2022 21:05
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 3, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 3, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 3, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 3, 2022

Result of foundationdb-pr-clang on Linux CentOS 7

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 3, 2022

Result of foundationdb-pr on Linux CentOS 7

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 3, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Nov 4, 2022

Doxense CI Report for Windows 10

@jzhou77 jzhou77 merged commit 2639739 into apple:release-7.1 Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liquid-helium liquid-helium Awaiting requested review from liquid-helium

2 more reviewers

@halfprice halfprice halfprice approved these changes

@flowguru flowguru flowguru approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jzhou77 @foundationdb-ci @fdb-windows-ci @halfprice @flowguru @sfc-gh-anoyes