Skip to content

Fix assertion failure due to empty rwImpls in SpecialKeySpaceCorrectness workload #8653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jzhou77 merged 3 commits into from
Nov 2, 2022
Merged

Fix assertion failure due to empty rwImpls in SpecialKeySpaceCorrectness workload #8653

jzhou77 merged 3 commits into from
Nov 2, 2022

Conversation

@jzhou77
Copy link
Contributor

@jzhou77 jzhou77 commented Nov 1, 2022 •
edited
Loading

This is a 0.2^10=.0000001024 probability event.

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@jzhou77 jzhou77 requested a review from sfc-gh-clin November 1, 2022 17:00
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 1, 2022

Result of foundationdb-pr-clang-ide on Linux CentOS 7

  • Commit ID: 9437658
  • Duration 0:12:35
  • Result: ❌ FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 1, 2022

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 9437658
  • Duration 0:12:56
  • Result: ❌ FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 1, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 9437658
  • Duration 0:14:20
  • Result: ❌ FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 1, 2022

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 9437658
  • Duration 0:14:27
  • Result: ❌ FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 1, 2022

Result of foundationdb-pr-macos on macOS Monterey 12.x

  • Commit ID: 9437658
  • Duration 0:22:25
  • Result: ❌ FAILED
  • Error: Error while executing command: ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -i ${HOME}/.ssh_key ec2-user@${MAC_EC2_HOST} /usr/local/bin/bash --login -c ./build_pr_macos.sh. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Nov 1, 2022

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 1, 2022

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 73fb20d
  • Duration 0:12:05
  • Result: ❌ FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 1, 2022

Result of foundationdb-pr-clang-ide on Linux CentOS 7

  • Commit ID: 73fb20d
  • Duration 0:13:30
  • Result: ❌ FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 1, 2022

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 73fb20d
  • Duration 0:13:50
  • Result: ❌ FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 1, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 73fb20d
  • Duration 0:14:41
  • Result: ❌ FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Nov 1, 2022

Doxense CI Report for Windows 10

@jzhou77 jzhou77 mentioned this pull request Nov 1, 2022
Merged
5 tasks
@jzhou77 jzhou77 requested a review from halfprice November 1, 2022 21:33
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 2, 2022

Result of foundationdb-pr-clang-ide on Linux CentOS 7

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Nov 2, 2022

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 2, 2022

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 2c00661
  • Duration 0:26:56
  • Result: ❌ FAILED
  • Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 2, 2022

Result of foundationdb-pr-macos-m1 on macOS BigSur 11.5.2

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 2, 2022

Result of foundationdb-pr-clang on Linux CentOS 7

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 2, 2022

Result of foundationdb-pr-macos on macOS Monterey 12.x

sfc-gh-clin
sfc-gh-clin approved these changes Nov 2, 2022
View reviewed changes
Copy link
Collaborator

@sfc-gh-clin sfc-gh-clin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding this.

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Nov 2, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 2c00661
  • Duration 1:59:50
  • Result: ❌ FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@jzhou77 jzhou77 mentioned this pull request Nov 2, 2022
Closed
@jzhou77 jzhou77 merged commit dfaa577 into apple:main Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sfc-gh-clin sfc-gh-clin sfc-gh-clin approved these changes

+1 more reviewer

@halfprice halfprice halfprice approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

nightly correctness bugs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jzhou77 @foundationdb-ci @fdb-windows-ci @halfprice @sfc-gh-clin