Skip to content

Fix potential data corruptions [release 6.3] #8558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jzhou77 merged 4 commits into from
Oct 25, 2022
Merged

Fix potential data corruptions [release 6.3] #8558

jzhou77 merged 4 commits into from
Oct 25, 2022

Conversation

@jzhou77
Copy link
Contributor

@jzhou77 jzhou77 commented Oct 24, 2022 •
edited
Loading

Cherrypick #8526 and #8522

300k 20221024-221958-jzhou-ca54e126a2a47f40 passed.

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

sfc-gh-satherton and others added 2 commits October 24, 2022 13:15
@sfc-gh-satherton @jzhou77
Bug fix: If a disk queue reader drops its future memory corruption co…
53a2d4f 
…uld occur so the actor is made uncancellable and the TrackMe member will keep the disk queue alive until it finishes.
@jzhou77
Bug fixes in IO buffer and class lifetimes, Generic actor improvements.
b6b54b9
@jzhou77 jzhou77 changed the base branch from release-5.2 to release-6.3 October 24, 2022 21:15
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Oct 24, 2022

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: b6b54b9
  • Duration 0:03:36
  • Result: ❌ FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Oct 24, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: b6b54b9
  • Duration 0:03:35
  • Result: ❌ FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Oct 24, 2022

Result of foundationdb-pr-macos-m1 on macOS BigSur 11.5.2

  • Commit ID: b6b54b9
  • Duration 0:04:51
  • Result: ❌ FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Oct 24, 2022

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: b6b54b9
  • Duration 0:04:55
  • Result: ❌ FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Oct 24, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 6d4a863
  • Duration 0:04:38
  • Result: ❌ FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Oct 24, 2022

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 6d4a863
  • Duration 0:04:40
  • Result: ❌ FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Oct 24, 2022

Result of foundationdb-pr-clang on Linux CentOS 7

  • Commit ID: 912f46d
  • Duration 0:04:11
  • Result: ❌ FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Oct 24, 2022

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 6d4a863
  • Duration 0:09:25
  • Result: ❌ FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Oct 24, 2022

Result of foundationdb-pr-macos-m1 on macOS BigSur 11.5.2

  • Commit ID: 6d4a863
  • Duration 0:09:29
  • Result: ❌ FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Oct 24, 2022

Result of foundationdb-pr-macos on macOS Monterey 12.x

  • Commit ID: 6d4a863
  • Duration 0:09:35
  • Result: ❌ FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@jzhou77 jzhou77 marked this pull request as ready for review October 24, 2022 22:52
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Oct 24, 2022

Result of foundationdb-pr on Linux CentOS 7

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Oct 24, 2022

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Oct 24, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

@jzhou77 jzhou77 merged commit 1d59860 into apple:release-6.3 Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xumengpanda xumengpanda Awaiting requested review from xumengpanda

2 more reviewers

@halfprice halfprice halfprice approved these changes

@liquid-helium liquid-helium liquid-helium approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jzhou77 @foundationdb-ci @fdb-windows-ci @halfprice @liquid-helium @sfc-gh-satherton