Skip to content

check if fetchKeys is covered by blob storage #7965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sfc-gh-huliu merged 1 commit into from
Aug 26, 2022
Merged

check if fetchKeys is covered by blob storage #7965

sfc-gh-huliu merged 1 commit into from
Aug 26, 2022

Conversation

@sfc-gh-huliu
Copy link
Collaborator

@sfc-gh-huliu sfc-gh-huliu commented Aug 23, 2022

Check if a range is fully covered for StorageServer FetchKeys. If not, throw exception and log trace

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Aug 23, 2022

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 23, 2022

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 23, 2022

Result of foundationdb-pr on Linux CentOS 7

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 23, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 873bc25
  • Duration 4:17:22
  • Result: ❌ FAILED
  • Error: Build has timed out.
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@sfc-gh-huliu sfc-gh-huliu force-pushed the check branch 2 times, most recently from b982f51 to 342a75a Compare August 24, 2022 17:46
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 24, 2022

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: b982f51
  • Duration 0:10:56
  • Result: ❌ FAILED
  • Error: reference not found for primary source and source version b982f51ac13b4e77551b939390858c9468bc11e5
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 24, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: b982f51
  • Duration 0:11:20
  • Result: ❌ FAILED
  • Error: reference not found for primary source and source version b982f51ac13b4e77551b939390858c9468bc11e5
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Aug 24, 2022

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 24, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 342a75a
  • Duration 0:37:05
  • Result: ❌ FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 24, 2022

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 342a75a
  • Duration 0:37:55
  • Result: ❌ FAILED
  • Error: Error while executing command: ninja -v -C build_output -j ${NPROC} all packages strip_targets. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Aug 24, 2022

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 24, 2022

Result of foundationdb-pr on Linux CentOS 7

@sfc-gh-huliu sfc-gh-huliu marked this pull request as ready for review August 24, 2022 23:58
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 25, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

sfc-gh-jslocum
sfc-gh-jslocum previously approved these changes Aug 26, 2022
View reviewed changes
@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Aug 26, 2022

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 26, 2022

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: fbc01f8
  • Duration 0:45:35
  • Result: ❌ FAILED
  • Error: Error while executing command: ctest -j ${NPROC} --no-compress-output -T test --output-on-failure. Reason: exit status 8
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Aug 26, 2022

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 26, 2022

Result of foundationdb-pr on Linux CentOS 7

@sfc-gh-jslocum sfc-gh-jslocum self-requested a review August 26, 2022 22:45
@sfc-gh-huliu sfc-gh-huliu merged commit 945dd37 into apple:main Aug 26, 2022
@sfc-gh-huliu sfc-gh-huliu deleted the check branch August 26, 2022 22:52
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 27, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 27, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: b7d4453
  • Duration 3:42:33
  • Result: ❌ FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@kakaiu kakaiu mentioned this pull request Mar 13, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sfc-gh-jslocum sfc-gh-jslocum sfc-gh-jslocum approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sfc-gh-huliu @fdb-windows-ci @foundationdb-ci @sfc-gh-jslocum