Skip to content

Remove extremely spammy trace event in FetchKeys #7883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sfc-gh-jslocum merged 2 commits into from
Aug 15, 2022
Merged

Remove extremely spammy trace event in FetchKeys #7883

sfc-gh-jslocum merged 2 commits into from
Aug 15, 2022

Conversation

@sfc-gh-satherton
Copy link
Collaborator

@sfc-gh-satherton sfc-gh-satherton commented Aug 13, 2022

Remove extremely spammy trace event in FetchKeys by only logging the re-enabling of locality load balance if it was previously disabled.

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@sfc-gh-satherton
Remove extremely spammy trace event by only logging the re-enabling o…
9ac75c5 
…f load balance in FetchKeys if it was disabled.
@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Aug 13, 2022

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 13, 2022

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 9ac75c5
  • Duration 0:57:49
  • Result: ❌ FAILED
  • Error: Error while executing command: if python3 -m joshua.joshua list --stopped | grep ${ENSEMBLE_ID} | grep -q 'pass=10[0-9][0-9][0-9]'; then echo PASS; else echo FAIL && exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 13, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 9ac75c5
  • Duration 1:19:53
  • Result: ❌ FAILED
  • Error: Error in UPLOAD_ARTIFACTS phase: [fdb-kubernetes-tests: [report files not found in build]]
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

sfc-gh-satherton added a commit to sfc-gh-satherton/foundationdb that referenced this pull request Aug 15, 2022
@sfc-gh-satherton
Remove extremely spammy trace event in FetchKeys (Cherry-pick apple#7883
49ec186 
 to snowflake/release-71.2)
@sfc-gh-satherton sfc-gh-satherton mentioned this pull request Aug 15, 2022
Merged
5 tasks
sfc-gh-jslocum added a commit that referenced this pull request Aug 15, 2022
@sfc-gh-jslocum
Merge pull request #7892 from sfc-gh-satherton/pr-7883-snowflake-71.2
d9ff562 
Remove extremely spammy trace event in FetchKeys (Cherry-pick #7883 to snowflake/release-71.2)
@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Aug 15, 2022

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 15, 2022

Result of foundationdb-pr on Linux CentOS 7

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 15, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: f2f6148
  • Duration 1:41:22
  • Result: ❌ FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@sfc-gh-jslocum sfc-gh-jslocum merged commit 2448d9e into apple:main Aug 15, 2022
@jzhou77 jzhou77 mentioned this pull request Aug 19, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sfc-gh-jslocum sfc-gh-jslocum sfc-gh-jslocum approved these changes

Assignees

@sfc-gh-jslocum sfc-gh-jslocum

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sfc-gh-satherton @fdb-windows-ci @foundationdb-ci @sfc-gh-jslocum