Skip to content

Buggify GRV proxy to return errors and fix bugs found [release 7.1] #7860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jzhou77 merged 10 commits into from
Aug 16, 2022
Merged

Buggify GRV proxy to return errors and fix bugs found [release 7.1] #7860

jzhou77 merged 10 commits into from
Aug 16, 2022

Conversation

@jzhou77
Copy link
Contributor

@jzhou77 jzhou77 commented Aug 12, 2022 •
edited
Loading

Cherrypick #7844

Note this will not change to use the new error code grv_proxy_memory_limit_exceeded.

100k 20220811-235034-jzhou-19c1f48e9fc7bb5c passed.
100k 20220815-213725-jzhou-11174bc685813ca0 passed.

Code-Reviewer Section

The general pull request guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Aug 12, 2022

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 12, 2022

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 581819e
  • Duration 0:53:03
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 12, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 581819e
  • Duration 1:34:55
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@jzhou77
Increase waitForLowInFlight timeout
6a65f70 
Seeing a CheckRelocation test failed with 300s timeout.
@jzhou77 jzhou77 marked this pull request as ready for review August 15, 2022 21:31
@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Aug 15, 2022

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 15, 2022

Result of foundationdb-pr on Linux CentOS 7

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 15, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 6a65f70
  • Duration 1:31:02
  • Result: ❌ FAILED
  • Error: Error while executing command: if $(grep -q -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log); then echo "TESTS FAILED SEE THESE LOGS:"; echo ; grep -l -- "--- FAIL:" ${CODEBUILD_SRC_DIR}/fdb-kubernetes-tests/logs/*.log; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)
  • Build Artifact (available for 30 days)

@jzhou77 jzhou77 merged commit e253c19 into apple:release-7.1 Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xis19 xis19 xis19 approved these changes

@sfc-gh-mpilman sfc-gh-mpilman Awaiting requested review from sfc-gh-mpilman

+1 more reviewer

@flowguru flowguru flowguru approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jzhou77 @fdb-windows-ci @foundationdb-ci @xis19 @flowguru