Skip to content

Cherry-pick pull request #7671 #7800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sfc-gh-clin merged 1 commit into from
Aug 9, 2022
Merged

Cherry-pick pull request #7671 #7800

sfc-gh-clin merged 1 commit into from
Aug 9, 2022

Conversation

@sfc-gh-clin
Copy link
Collaborator

@sfc-gh-clin sfc-gh-clin commented Aug 5, 2022 •
edited
Loading

Cherry-pick #7671 with only the fix as the test in this version is different.

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 5, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: 406f937
  • Duration 0:04:36
  • Result: ❌ FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 5, 2022

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: 406f937
  • Duration 0:04:39
  • Result: ❌ FAILED
  • Error: Error while executing command: if [[ $(git diff --shortstat 2> /dev/null | tail -n1) == "" ]]; then echo "CODE FORMAT CLEAN"; else echo "CODE FORMAT NOT CLEAN"; echo; echo "THE FOLLOWING FILES NEED TO BE FORMATTED"; echo; git ls-files -m; echo; exit 1; fi. Reason: exit status 1
  • Build Logs (available for 30 days)

@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Aug 5, 2022

Doxense CI Report for Windows 10

@sfc-gh-clin sfc-gh-clin force-pushed the cherry-pick-7671-6.3 branch from 406f937 to a069900 Compare August 5, 2022 22:09
@fdb-windows-ci
Copy link
Collaborator

fdb-windows-ci commented Aug 5, 2022

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 5, 2022

Result of foundationdb-pr on Linux CentOS 7

  • Commit ID: a069900
  • Duration 0:39:55
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 5, 2022

Result of foundationdb-pr-cluster-tests on Linux CentOS 7

  • Commit ID: a069900
  • Duration 0:48:21
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@sfc-gh-clin sfc-gh-clin self-assigned this Aug 6, 2022
@foundationdb-ci
Copy link
Contributor

foundationdb-ci commented Aug 9, 2022

Result of foundationdb-pr-macos on macOS BigSur 11.5.2

  • Commit ID: a069900
  • Duration 0:17:56
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@sfc-gh-clin sfc-gh-clin merged commit be8b344 into apple:release-6.3 Aug 9, 2022
@sfc-gh-clin sfc-gh-clin deleted the cherry-pick-7671-6.3 branch August 9, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sfc-gh-xwang sfc-gh-xwang sfc-gh-xwang approved these changes

@sfc-gh-ljoswiak sfc-gh-ljoswiak sfc-gh-ljoswiak approved these changes

@sfc-gh-anoyes sfc-gh-anoyes Awaiting requested review from sfc-gh-anoyes

Assignees

@sfc-gh-clin sfc-gh-clin

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sfc-gh-clin @foundationdb-ci @fdb-windows-ci @sfc-gh-xwang @sfc-gh-ljoswiak